X Tutup
Skip to content

Add tab menu button to list currently opened scenes#108079

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
arkology:scenes-list
Nov 14, 2025
Merged

Add tab menu button to list currently opened scenes#108079
Repiteo merged 1 commit intogodotengine:masterfrom
arkology:scenes-list

Conversation

@arkology
Copy link
Contributor

@arkology arkology commented Jun 28, 2025

Attempt to resolve a problem raised in godotengine/godot-proposals#9954.

godot.windows.editor.dev.x86_64_8oll5CHTSk.mp4
Previous version, different dropdown icon (reverted after KoBeWi comment)
godot.windows.editor.dev.x86_64_VfAuMUlzC3.mp4

Closes godotengine/godot-proposals#9954

@arkology arkology requested review from a team as code owners June 28, 2025 13:56
@KoBeWi KoBeWi added this to the 4.x milestone Jun 28, 2025
@arkology
Copy link
Contributor Author

arkology commented Jun 28, 2025

Interesting, in fork I don't have failed stylecheck action (https://github.com/arkology/godot/actions/runs/15944544374)
Upd: No edits in SVGs - no errors 😆

@KoBeWi
Copy link
Member

KoBeWi commented Jun 28, 2025

I'm not sure if this needs a new icon, you can just use the GuiTabMenuHl.

@arkology
Copy link
Contributor Author

arkology commented Jun 28, 2025

I'm not sure if this needs a new icon, you can just use the GuiTabMenuHl.

Originally I used GuiTabMenuHl (you can see it in linked feature request issue), but then looked how it is done in other places like Notepad++ and Visual Studio.
If this is preferable, I'll revert it.

@seppoday
Copy link

I wonder if we need arrows now? I personally don't see myself using arrows when there is dropdown

@arkology
Copy link
Contributor Author

I think still keeping them is ok because they indicate that there are invisible tabs.

@piotrtrkostrzewski94
Copy link

Hello, great idea, in my opinion a good extension of functionality would be to add a search engine, it would be useful when someone has so many scenes that entering the name will be faster for them. Theoretically it could be done using TextEdit, what do you think?

@KoBeWi KoBeWi modified the milestones: 4.x, 4.6 Jun 29, 2025
@arkology
Copy link
Contributor Author

@piotrtrkostrzewski94 PopupMenu already has some kind of search functionality (https://docs.godotengine.org/en/stable/classes/class_popupmenu.html#class-popupmenu-property-allow-search).
More extended search functionality could be added in follow-up pr.

@piotrtrkostrzewski94
Copy link

@arkology Thank you very much

@arkology arkology requested a review from a team August 23, 2025 10:44
@arkology
Copy link
Contributor Author

Rebased because GitHub was showing conflicts.

@nubels
Copy link
Contributor

nubels commented Oct 8, 2025

I really like this feature. There's a problem on macOS though: the shortcut KeyModifierMask::ALT | Key::L is what you use to type @, meaning you can't write things like @export when this button is present.

@arkology
Copy link
Contributor Author

arkology commented Oct 8, 2025

@nubels unfortunately I don't have macOS to tell which shortcut is free.
Fell free to suggest another combination.

@nubels
Copy link
Contributor

nubels commented Oct 8, 2025

@arkology ALT+K, ALT + I, ALT + T would work for example. I assume you chose L because it stands for list? If that's to unintuitive I'm not 100% sure if we need a shortcut for this button in general.

@arkology
Copy link
Contributor Author

arkology commented Oct 9, 2025

Changed to ALT + T

@Repiteo Repiteo merged commit 26fd075 into godotengine:master Nov 14, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 14, 2025

Thanks!

@arkology arkology deleted the scenes-list branch November 14, 2025 20:31
@akien-mga akien-mga changed the title Add opened scenes list button Add tab menu button to list currently opened scenes Nov 27, 2025
Copilot AI added a commit to TekisasuEngine/tekisasu that referenced this pull request Dec 5, 2025
…ngine#108079)

Co-authored-by: Tekisasu-JohnK <80524176+Tekisasu-JohnK@users.noreply.github.com>
Tekisasu-JohnK added a commit to TekisasuEngine/tekisasu that referenced this pull request Dec 5, 2025
…ngine#108079) (#46)

* Backport: Add tab menu button to list currently opened scenes (godotengine#108079)
* Add BACKPORTS.md documentation for upstream PR backport

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Tekisasu-JohnK <80524176+Tekisasu-JohnK@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add row(s) to scenes tab for a better overview of open scenes

6 participants

X Tutup