Remove unused methods in ResourceLoader#108076
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 30, 2025
Merged
Conversation
Ivorforce
approved these changes
Jul 2, 2025
Member
Ivorforce
left a comment
Ivorforce
left a comment
There was a problem hiding this comment.
Reducing code is good. We can re-add if need arises.
akien-mga
approved these changes
Oct 29, 2025
Member
akien-mga
left a comment
akien-mga
left a comment
There was a problem hiding this comment.
Seems good. A rebase would be nice before merging so we make sure those are still unused (and avoid potentially landing on a too old commit when bisecting).
timothyqiu
force-pushed
the
resource-loader-unused
branch
from
c333ffb to
c885098
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_import_order(path): Added in 423ca9b. Never been used.has_custom_uid_support(path): Added in Universalize UID support in all resource types #97352. Replaced by calling loader methods directly insideshould_create_uid_file()in Improve UID file creation condition #102489.