X Tutup
Skip to content

Improve error message when UID main scene is not found#108075

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
KoBeWi:main_without_main_is_just_
Sep 22, 2025
Merged

Improve error message when UID main scene is not found#108075
Repiteo merged 1 commit intogodotengine:masterfrom
KoBeWi:main_without_main_is_just_

Conversation

@KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jun 28, 2025

Related: #107695
image

@KoBeWi KoBeWi added this to the 4.x milestone Jun 28, 2025
@KoBeWi KoBeWi requested a review from a team as a code owner June 28, 2025 11:56
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected. Code looks good to me.

Something I find strange is that on Windows, if you use --headless, it will still spawn an alert dialog (and be blocking). I thought we already skipped all dialog creation when in headless mode (and therefore made it non-blocking), but maybe we're only doing that on Linux.

@Repiteo Repiteo modified the milestones: 4.x, 4.6 Sep 20, 2025
@Repiteo Repiteo merged commit b059849 into godotengine:master Sep 22, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 22, 2025

Thanks!

@AThousandShips
Copy link
Member

AThousandShips commented Sep 23, 2025

This fails for any project that hasn't previously been opened, regardless of running with --import, it can only be recovered by removing any main scene and running, as the UID cache is not generated

Something is clearly incorrect here in how this is done, I especially think it isn't correct to fail launching the editor when the main scene isn't cached

Edit: Opened an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup