Fix mouse_entered and mouse_exited Signals being emitted too early#107955
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Sep 19, 2025
Merged
Fix mouse_entered and mouse_exited Signals being emitted too early#107955Repiteo merged 1 commit intogodotengine:masterfrom
mouse_entered and mouse_exited Signals being emitted too early#107955Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
AThousandShips
changed the title
MouseEntered and MouseExited Signals being emitted too earlymouse_entered and mouse_exited Signals being emitted too early
KoBeWi
approved these changes
Jun 30, 2025
Member
KoBeWi
left a comment
KoBeWi
left a comment
There was a problem hiding this comment.
Seems fine.
Control changes are prone to regressions though (even if they are "perfectly safe"), so it will have to wait for 4.6.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106953
Currently, the
mouse_enteredandmouse_exitedsignals are emitted in thenotificationmethod ofControl. Since notifications are propagated downward from Control to inherited classes and downwards, this means that the signal will be emitted before any inherited classes have the chance to update their state based on the notification.For example, in the
Buttonclass,is_hoveredwill not update before the signal is emitted and therefore any code that checks the state will have out of date values. This PR delays the signal emission until after thenotification()call is fully propagated in order to give time for the internal classes to update their state.I suppose if another solution isn't found that there should be discussion on how often users would call
notification(NOTIFICATION_MOUSE_ENTERED)and expect a signal to be emitted. Ideally this would be called after the other classes, it would work with a deferred call but that should be discussed for latency.