X Tutup
Skip to content

Improve auto-translation of the rendering method selector#107795

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
timothyqiu:renderer-selection-i18n
Nov 14, 2025
Merged

Improve auto-translation of the rendering method selector#107795
Repiteo merged 1 commit intogodotengine:masterfrom
timothyqiu:renderer-selection-i18n

Conversation

@timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Jun 21, 2025

Follow-up to #107624
Part of #104574

  • Some simple refactoring are done in order to make the button auto-translatable.
  • Removed two unnecessary member variables.
    • renderer_request: bind as callback argument instead.
    • renderer_current: can be determined by checking the current project settings.
  • Made the rendering method change confirm dialog lazy-created.

@timothyqiu timothyqiu force-pushed the renderer-selection-i18n branch from 61bf8fa to 6c06497 Compare July 9, 2025 04:41
@KoBeWi KoBeWi modified the milestones: 4.x, 4.6 Jul 9, 2025
@Repiteo Repiteo merged commit 814138e into godotengine:master Nov 14, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 14, 2025

Thanks!

@timothyqiu timothyqiu deleted the renderer-selection-i18n branch November 15, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup