Apply sun scatter from lights with shadows in compatibility#107740
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 6, 2025
Merged
Apply sun scatter from lights with shadows in compatibility#107740Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
Kaleb-Reid
force-pushed
the
compat-directional-shadow-scatter
branch
2 times, most recently
from
79a49e2 to
301ba18
Compare
Kaleb-Reid
force-pushed
the
compat-directional-shadow-scatter
branch
from
301ba18 to
c7ded01
Compare
Calinou
approved these changes
Jun 26, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally, it works as expected in all rendering methods (including with multiple DirectionalLights).
Code looks good to me.
Testing project: test-sun-scatter.zip
| Forward+ | Mobile | Compatibility |
|---|---|---|
 |
 |
 |
Kaleb-Reid
force-pushed
the
compat-directional-shadow-scatter
branch
from
c7ded01 to
18a8bf8
Compare
Contributor
Author
|
Rebased onto master |
Kaleb-Reid
force-pushed
the
compat-directional-shadow-scatter
branch
from
18a8bf8 to
c20ab94
Compare
Contributor
Author
|
@clayjohn Had to fix this pr as well due to |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently sun scatter does not affect scene objects for lights that have shadows in Compatibility because
directional_light_countinscene.glsldoes not include lights with shadows so that they can each be applied in separate passes from each other. This pr passes in the number of lights with shadows so that they can be factored into the sun scatter.Before:
After:
In both images the cube is fully outside the depth end of the fog and should be fully obscured as is the case both without shadows enabled for the light in Compatibility and always in Forward+.