Add MultiMesh physics interpolation for 2D transforms (MultiMeshInstance2D)#107666
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 3, 2025
Merged
Conversation
AThousandShips
changed the title
lawnjelly
reviewed
Jun 18, 2025
Member
|
This looks great! As discussed on RC, I likely just forgot to add this wrapper, all the backend should be the same as used by Any testing would be great, and I'll try and test. |
lawnjelly
reviewed
Jun 18, 2025
Sch1nken
force-pushed
the
add-physics-interpolation-multimesh2d
branch
from
9f7fa7d to
004cff5
Compare
Contributor
Author
|
I added the mentioned changes. All squashed into 1 commit. I also added a simple test project in the intitial post. |
Sch1nken
force-pushed
the
add-physics-interpolation-multimesh2d
branch
2 times, most recently
from
a51fc31 to
69d7238
Compare
…tance2D) Replicated MultimeshInstance3D behaviour to MultiMeshInstance2D and added mesh_storage for 2D transform Also call VisualInstance::_physics_interpolated_changed() Use Node instead of VisualInstance. Addded comment Fixed typo :) Using CanvasItem instead of Node now. Made CanvasItem::_physics_interpolated_changed() protected
Sch1nken
force-pushed
the
add-physics-interpolation-multimesh2d
branch
from
2358e1e to
a9ac00f
Compare
lawnjelly
approved these changes
Jun 18, 2025
Member
lawnjelly
left a comment
lawnjelly
left a comment
There was a problem hiding this comment.
Providing it passes CI (I think there's some CI problem at the moment).
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I already discussed this on rocket chat. The docs wrongly state that MultiMeshInstance2D (or rather MultiMesh with 2D Transforms) make use of physics interpolation (https://docs.godotengine.org/en/latest/tutorials/physics/interpolation/2d_and_3d_physics_interpolation.html#other). After some fiddling I discovered that this was not the case.
So here is a hopefully decent implementation I basically replicated MultimeshInstance3D behaviour to MultiMeshInstance2D and added mesh_storage for 2D transforms.
Edit:
Small Testproject: MultiMesh2D_Interp_Test.zip
(Use space bar to toggle physics interpolation for the meshinstance on/off)