X Tutup
Skip to content

Show "No Translations Configured" message for empty translation preview menu#107649

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
timothyqiu:no-translations-configured
Sep 23, 2025
Merged

Show "No Translations Configured" message for empty translation preview menu#107649
Repiteo merged 1 commit intogodotengine:masterfrom
timothyqiu:no-translations-configured

Conversation

@timothyqiu
Copy link
Member

When no translations are configured in Project Settings, the preview menu currently only shows the "None" option (for not using any translation).

This PR adds a message to the locale list section so that users not familiar with this feature are less confused about what they should do.

Before

no-tr-before

After

no-tr-after

@timothyqiu timothyqiu added this to the 4.x milestone Jun 18, 2025
@timothyqiu timothyqiu requested a review from a team as a code owner June 18, 2025 00:50
@timothyqiu timothyqiu requested a review from a team as a code owner June 18, 2025 00:50
@KoBeWi
Copy link
Member

KoBeWi commented Jun 18, 2025

This PR adds a message to the locale list section so that users not familiar with this feature are less confused about what they should do.

That doesn't make it much more helpful. You could add a tooltip mentioning that you should add a translation in Project Settings.

@timothyqiu timothyqiu force-pushed the no-translations-configured branch from 4e8ed11 to 8821c75 Compare June 18, 2025 09:10
@timothyqiu timothyqiu force-pushed the no-translations-configured branch from 8821c75 to 3216196 Compare June 18, 2025 09:44
@timothyqiu timothyqiu force-pushed the no-translations-configured branch from 3216196 to a760a76 Compare July 5, 2025 06:45
@Repiteo Repiteo modified the milestones: 4.x, 4.6 Sep 23, 2025
@Repiteo Repiteo merged commit c21e977 into godotengine:master Sep 23, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 23, 2025

Thanks!

@timothyqiu timothyqiu deleted the no-translations-configured branch September 23, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup