Add support for closing dialog windows with Cmd+W on macOS#107303
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 22, 2025
Merged
Add support for closing dialog windows with Cmd+W on macOS#107303Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
bruvzg
reviewed
Jun 9, 2025
Member
bruvzg
left a comment
bruvzg
left a comment
There was a problem hiding this comment.
Cmd + W is a standard macOS shortcut, and separate ui_close_dialog make sense. As long as it's not conflicting with anything (seems like it's not, the same shortcut is already used to close scene/script editor) it should be fine.
passivestar
force-pushed
the
close-dialog-action
branch
from
b3eac64 to
979f8fa
Compare
Contributor
Author
|
Removed the unnecessary display name override as per #107487 |
bruvzg
approved these changes
Oct 22, 2025
Ivorforce
reviewed
Oct 22, 2025
Comment on lines
+455
to
+458
| inputs = List<Ref<InputEvent>>(); | ||
| inputs.push_back(InputEventKey::create_reference(Key::W | KeyModifierMask::META)); | ||
| inputs.push_back(InputEventKey::create_reference(Key::ESCAPE)); | ||
| default_builtin_cache.insert("ui_close_dialog.macos", inputs); |
Member
There was a problem hiding this comment.
Does this mean that escape and cmd w both do the same thing in some situations? I don't think that would be standard macOS behavior.
Member
There was a problem hiding this comment.
It's not, but ESC is the current key for closing dialogs, so no reason to remove it.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
ui_close_dialogaction to allow support for Cmd+W on macOS.dialog_close_on_escapeproperty is kept unchanged. Closes godotengine/godot-proposals#9311, closes #86200