Always use a dark background for 3D editor overlays even with light theme#107154
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 18, 2025
Merged
Conversation
KoBeWi
approved these changes
Jun 20, 2025
Member
|
So #106664 made me wonder if it's really necessary to duplicate icon files. There must be a better way. |
Contributor
|
Needs rebase |
…heme This results in better readability against mixed-color backgrounds, as what you see in the 3D editor doesn't change depending on your editor theme. This also tweaks the viewport zoom/speed label for better readability by using a bold font and thicker outline.
Calinou
force-pushed
the
3d-editor-light-theme-use-dark-background
branch
from
a29340b to
d823a69
Compare
Member
Author
|
Rebased and tested again (on both Modern and Classic themes), it works as expected. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This results in better readability against mixed-color backgrounds, as what you see in the 3D editor doesn't change depending on your editor theme.
This also tweaks the viewport zoom/speed label for better readability by using a bold font and thicker outline, and fixes the zoom/speed icons being too dark on a light theme.
Preview
Dark theme
Light theme
Frame Time panel: