Improve performance of CSharpLanguage::reload_assemblies#106299
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 30, 2025
Merged
Conversation
akien-mga
changed the title
CSharpLanguage::reload_assemblies
raulsntos
reviewed
May 12, 2025
Member
raulsntos
left a comment
raulsntos
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I think it's a great idea to try and batch these updates if we can.
I'm a bit concerned with moving the EditorFileSystem::update_file call from CSharpScript::reload, since there are many other places where this method is called besides CSharpLanguage::reload_assemblies, and we may want to make sure the EditorFileSystem is still updated in those cases.
Maybe there's a way to queue these updates so they don't happen immediately, and instead the update happens once in the next frame (not sure if that may be too late).
Ryan-000
force-pushed
the
improve-CSharpLanguage-reload_assemblies-performance
branch
from
5031343 to
ba3106b
Compare
Ryan-000
force-pushed
the
improve-CSharpLanguage-reload_assemblies-performance
branch
from
ba3106b to
71708f8
Compare
raulsntos
reviewed
Jun 23, 2025
Ryan-000
force-pushed
the
improve-CSharpLanguage-reload_assemblies-performance
branch
from
71708f8 to
213e68a
Compare
akien-mga
force-pushed
the
improve-CSharpLanguage-reload_assemblies-performance
branch
from
213e68a to
f68bf2f
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before each individual CSharpScript would call
EditorFileSystem::update_fileduring assembly reload, which would cause performance problems and a freeze (especially with a large amount scripts) due toEditorFileSystem::_update_script_classes()being called for each file.This PR batches the updates resolving the issue.