CI: Build macOS binary without Vulkan if Vulkan SDK fails installing#104307
CI: Build macOS binary without Vulkan if Vulkan SDK fails installing#104307Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
akien-mga
added
the
cherrypick:4.4
|
I wonder if we can make it output a warning like when the cache fails to save to make it more clear when looking at CI to ensure we can rebuild it once the upstream issues goes away to ensure we don't merge without ensuring it builds safely with Vulkan |
Maybe related: https://stackoverflow.com/q/74907704/14664861 |
akien-mga
force-pushed
the
ci-macos-vulkan-sdk-optional
branch
from
d295d7b to
e151419
Compare
I changed it to an explicit warning:
On the other hand I don't think it should be a sign that we should hold off merging a PR until it's resolved, because at this point to explicit failure we currently have without this PR is good enough. It's rare that a PR would specifically impact the ability for macOS only to build for Vulkan, so for the vast majority of PRs, it should be no problem if we merge a PR that had a |
It's not rare for this step to fail, either due to network errors, or occasional changes in how the Vulkan SDK is distributed which require editing our script.
akien-mga
force-pushed
the
ci-macos-vulkan-sdk-optional
branch
from
e151419 to
b84828b
Compare
|
Note: The LunarG website is back online so the step is no longer failing. |
|
Thanks! |
5 participants
It's not rare for this step to fail, either due to network errors, or occasional changes in how the Vulkan SDK is distributed which require editing our script.
Today it started failing because https://sdk.lunarg.com/ returns error 502: Bad Gateway.
A drawback of this change is that if the Vulkan SDK does change setup and the step fails due to other aspects than network errors, we won't catch it right away. We'd need to manually check the log once in a while to confirm that it's still being installed and enabled fine. But it's probably ok.