X Tutup
Skip to content

Expose 3D editor snap settings to EditorInterface#103608

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
gr8alpaca:expose_node_3d_snapping
Sep 19, 2025
Merged

Expose 3D editor snap settings to EditorInterface#103608
Repiteo merged 1 commit intogodotengine:masterfrom
gr8alpaca:expose_node_3d_snapping

Conversation

@gr8alpaca
Copy link
Contributor

Implements #10704
Modified version of #96763

Adds methods to the EditorInterface (Instead of EditorPlugin) to get 3D editor snap settings. Snap values are affected by the shift key being held down when methods are called, decided against putting this in documentation as it is an intended interaction.

@gr8alpaca gr8alpaca requested a review from a team as a code owner March 5, 2025 04:33
@AThousandShips AThousandShips added this to the 4.x milestone Mar 5, 2025
@gr8alpaca gr8alpaca force-pushed the expose_node_3d_snapping branch 2 times, most recently from b8c8e22 to 8f46b5b Compare March 5, 2025 15:59
Copy link

@sepler sepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gr8alpaca gr8alpaca force-pushed the expose_node_3d_snapping branch 6 times, most recently from c904446 to a6ba149 Compare March 12, 2025 12:51
@AThousandShips
Copy link
Member

Please avoid pushing so many times in a row, if you need to run CI repeatedly please create a separate branch and run it on your own fork

@gr8alpaca gr8alpaca force-pushed the expose_node_3d_snapping branch from a6ba149 to 85dac40 Compare March 12, 2025 13:57
@gr8alpaca gr8alpaca force-pushed the expose_node_3d_snapping branch from 85dac40 to 4d80777 Compare March 12, 2025 14:03
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not following up on this, but yes, this is fine. I'll close the original version and we can merge this since it already implements @akien-mga's recommended changes.

@Repiteo Repiteo modified the milestones: 4.x, 4.6 Sep 19, 2025
@Repiteo Repiteo merged commit 9ef1ec5 into godotengine:master Sep 19, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 19, 2025

Thanks! Congratulations on your first merged contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup