Add switch on hover to TabBar by KoBeWi · Pull Request #103478 · godotengine/godot

KoBeWi · 2025-03-02T20:34:19Z

Docks will open when hovered during dragging.

ayOjP0dLwt.mp4

Same behavior exists in bottom panel.

EDIT:
Reworked to add switch_on_hover to TabBar. Now it works everywhere.

godot.windows.editor.dev.x86_64_8V0QtGUsXA.mp4

(pretty sure there was an issue for switch on hover for scenes)

editor/editor_dock_manager.cpp

Calinou

Tested locally, it works as expected.

Note that there's no delay after hovering a tab before it switches, which feels inconsistent with other actions like dragging items on top of inspector sections (which uses a delay configured in some project/editor setting). The delay avoids accidentally switching tabs when quickly dragging an item on top of unrelated tabs.

See KDE's Dolphin for comparison:

kde_dolphin_drag_and_drop_onto_tabs.mp4

KoBeWi · 2025-03-04T18:45:16Z

The bottom panel also doesn't have delay. It can be improved later I think.

kitbdev

It might be good to get #103601 in first for the drag and drop tests.

kitbdev · 2025-05-09T17:58:45Z

scene/gui/tab_bar.cpp

 			}
 		}
+	} else if (switch_on_hover && hover > -1 && hover != current) {
+		const_cast<TabBar *>(this)->set_current_tab(hover);


I don't really like how we do this in a const method, but it happens a lot in can_drop_data and the current alternatives aren't great. So its fine for now.

scene/gui/tab_bar.cpp

KoBeWi · 2025-05-16T13:23:16Z

Well, turns out there were quite a few issues with what I did (including TabContainer rearranging not working at all, though not sure if it was from the beginning or after my latest changes). I modified my approach a bit and it should be all working now.

kitbdev

This causes errors when dragging a node from the scene dock, switching to another scene by hovering over the scene tab bar, and trying to drop to the scene dock. It seems to sometimes crash, not sure how exactly to reproduce yet.
So the scene tree dock dragging logic will need some tweaks.

ERROR: Node not found: "/root/@EditorNode@21408/@Panel@14/@VBoxContainer@15/DockHSplitLeftL/DockHSplitLeftR/DockHSplitMain/@VBoxContainer@26/DockVSplitCenter/@VSplitContainer@54/@VBoxContainer@55/@EditorMainScreen@102/MainScreen/@CanvasItemEditor@11646/@VSplitContainer@11298/@HSplitContainer@11300/@HSplitContainer@11302/@Control@11303/@SubViewportContainer@11304/@SubViewport@11305/Control2/Control" (absolute path attempted from "/root/@EditorNode@21408/@Panel@14/@VBoxContainer@15/DockHSplitLeftL/DockHSplitLeftR/DockVSplitLeftR/DockSlotLeftUR/Scene/@SceneTreeEditor@5127").

There is also issues when trying to drag text between text edits in a similar way, when dragging between scenes changes the inspector and creates TextEdits. I guess this is because it never receives NOTIFICATION_DRAG_BEGIN since the dragging started before it existed.
ERROR: The main caret should not be removed. ERROR: scene\gui\tree.cpp:1509 - Index p_column = 0 is out of bounds (cells.size() = 0).
This seems like a larger dragging issue, and NOTIFICATION_DRAG_BEGIN should be sent to all new nodes while dragging is ongoing.

doc/classes/TabBar.xml

kitbdev · 2025-05-16T16:32:19Z

scene/gui/tab_bar.cpp

-	drag_data["type"] = p_type;
+	drag_data["type"] = "tab";
+	drag_data["tab_type"] = p_type;


Note that changing this means that some users may need to update it as well, see gilzoide/godot-dockable-container#24
Maybe instead we could keep the type the same and add a drag_data["is_rearrange_tab"] = true or something.

idk, consistent type makes more sense.
Technically this is not part of the API, so compatibility is not a concern here.

scene/gui/tab_bar.h

kitbdev · 2025-05-16T18:18:10Z

I reproduced the crash with a call stack.
I was dragging a scene tree dock node around for a while, hovering over another scene tree dock item after switching scenes and waiting a while.
It looks like the crash happens here:

Details

Exception has occurred: W32/0xC0000005
Unhandled exception thrown: read access violation.
p_item-> was 0x7FF700000102.

godot.windows.editor.dev.x86_64.exe!_restore_treeitem_custom_color(TreeItem * p_item) Line 82 (c:\Projects\godotsrc\godot\editor\scene_tree_dock.cpp:82)
godot.windows.editor.dev.x86_64.exe!SceneTreeDock::_inspect_hovered_node() Line 100 (c:\Projects\godotsrc\godot\editor\scene_tree_dock.cpp:100)
godot.windows.editor.dev.x86_64.exe!call_with_variant_args_helper<SceneTreeDock>(SceneTreeDock * p_instance, void(SceneTreeDock::*)() p_method, const Variant * * p_args, Callable::CallError & r_error, IndexSequence<> __formal) Line 223 (c:\Projects\godotsrc\godot\core\variant\binder_common.h:223)
godot.windows.editor.dev.x86_64.exe!call_with_variant_args<SceneTreeDock>(SceneTreeDock * p_instance, void(SceneTreeDock::*)() p_method, const Variant * * p_args, int p_argcount, Callable::CallError & r_error) Line 337 (c:\Projects\godotsrc\godot\core\variant\binder_common.h:337)
godot.windows.editor.dev.x86_64.exe!CallableCustomMethodPointer<SceneTreeDock,void>::call(const Variant * * p_arguments, int p_argcount, Variant & r_return_value, Callable::CallError & r_call_error) Line 103 (c:\Projects\godotsrc\godot\core\object\callable_method_pointer.h:103)
godot.windows.editor.dev.x86_64.exe!Callable::callp(const Variant * * p_arguments, int p_argcount, Variant & r_return_value, Callable::CallError & r_call_error) Line 57 (c:\Projects\godotsrc\godot\core\variant\callable.cpp:57)
godot.windows.editor.dev.x86_64.exe!Object::emit_signalp(const StringName & p_name, const Variant * * p_args, int p_argcount) Line 1288 (c:\Projects\godotsrc\godot\core\object\object.cpp:1288)
godot.windows.editor.dev.x86_64.exe!Node::emit_signalp(const StringName & p_name, const Variant * * p_args, int p_argcount) Line 4292 (c:\Projects\godotsrc\godot\scene\main\node.cpp:4292)
godot.windows.editor.dev.x86_64.exe!Object::emit_signal<>(const StringName & p_name) Line 930 (c:\Projects\godotsrc\godot\core\object\object.h:930)
godot.windows.editor.dev.x86_64.exe!Timer::_notification(int p_what) Line 64 (c:\Projects\godotsrc\godot\scene\main\timer.cpp:64)
godot.windows.editor.dev.x86_64.exe!Timer::_notification_forwardv(int p_notification) Line 36 (c:\Projects\godotsrc\godot\scene\main\timer.h:36)
godot.windows.editor.dev.x86_64.exe!Object::_notification_forward(int p_notification) Line 931 (c:\Projects\godotsrc\godot\core\object\object.cpp:931)
godot.windows.editor.dev.x86_64.exe!Object::notification(int p_notification, bool p_reversed) Line 879 (c:\Projects\godotsrc\godot\core\object\object.h:879)
godot.windows.editor.dev.x86_64.exe!SceneTree::_process_group(SceneTree::ProcessGroup * p_group, bool p_physics) Line 1183 (c:\Projects\godotsrc\godot\scene\main\scene_tree.cpp:1183)
godot.windows.editor.dev.x86_64.exe!SceneTree::_process(bool p_physics) Line 1263 (c:\Projects\godotsrc\godot\scene\main\scene_tree.cpp:1263)
godot.windows.editor.dev.x86_64.exe!SceneTree::process(double p_time) Line 697 (c:\Projects\godotsrc\godot\scene\main\scene_tree.cpp:697)
godot.windows.editor.dev.x86_64.exe!Main::iteration() Line 4747 (c:\Projects\godotsrc\godot\main\main.cpp:4747)
godot.windows.editor.dev.x86_64.exe!OS_Windows::run() Line 2278 (c:\Projects\godotsrc\godot\platform\windows\os_windows.cpp:2278)
godot.windows.editor.dev.x86_64.exe!widechar_main(int argc, wchar_t * * argv) Line 96 (c:\Projects\godotsrc\godot\platform\windows\godot_windows.cpp:96)
godot.windows.editor.dev.x86_64.exe!_main() Line 122 (c:\Projects\godotsrc\godot\platform\windows\godot_windows.cpp:122)

KoBeWi · 2025-05-17T21:29:32Z

The errors should be fixed now.

YeldhamDev · 2025-09-16T23:27:09Z

I don't think the switch should be instantaneous. In other places in the editor with the same mechanism, there's a brief pause before it happens.

KoBeWi · 2025-09-18T11:13:38Z

Which other place involves switching tabs and has a delay?

YeldhamDev · 2025-09-18T14:13:39Z

Not tabs specifically, but in the inspector for example, dragging something to a folded category will only unfold it after a few milliseconds:

Screencast_20250918_111256.webm

KoBeWi · 2025-09-18T15:39:14Z

As I already mentioned, the bottom panel (which is the closest to a tab bar with switch on hover) does not have delay:

godot.windows.editor.dev.x86_64_vUT2lrkHKM.mp4

If this PR adds a delay and #106164 gets merged, bottom panel will have the delay too. I can add it if this behavior change is ok (at least it will be consistent).

YeldhamDev · 2025-09-18T19:55:14Z

I would be in favor of the delay, as this behavior is what I see when using other software.

KoBeWi · 2025-09-18T20:19:58Z

Added the delay.

YeldhamDev

Windows warnings should be fixed, but overall looks good. Would be nice if the delay time would be centralized and shared by multiple UI elements, but that's for another PR.

Repiteo

scene/main/timer.h is no longer a transitive include

scene/gui/tab_bar.h

scene/gui/tab_bar.cpp

Repiteo · 2025-10-22T00:16:51Z

Thanks!

KoBeWi added enhancement topic:editor usability labels Mar 2, 2025

KoBeWi added this to the 4.x milestone Mar 2, 2025

KoBeWi requested a review from a team March 2, 2025 20:34

KoBeWi force-pushed the hover_witch branch from 07edffa to b4f5c71 Compare March 3, 2025 12:46

kitbdev reviewed Mar 3, 2025

View reviewed changes

editor/editor_dock_manager.cpp Outdated Show resolved Hide resolved

editor/editor_dock_manager.cpp Outdated Show resolved Hide resolved

KoBeWi force-pushed the hover_witch branch from b4f5c71 to 19f95f1 Compare March 4, 2025 13:11

KoBeWi requested review from a team as code owners March 4, 2025 13:11

KoBeWi force-pushed the hover_witch branch from 19f95f1 to ccbc75d Compare March 4, 2025 13:11

KoBeWi changed the title ~~Add switch on hover to dock tabs~~ Add switch on hover to TabBar Mar 4, 2025

Calinou reviewed Mar 4, 2025

View reviewed changes

kitbdev mentioned this pull request Mar 4, 2025

Allow TabBar drag and drop to be overridden and add tab mouse tests #103601

Merged

kitbdev mentioned this pull request May 10, 2025

Refactor editor EditorBottomPanel to be a TabContainer #106164

Merged

lodetrick mentioned this pull request May 15, 2025

TRACKER: Fully integrate the bottom panel with docks godotengine/godot-proposals#12430

Closed

15 tasks

kitbdev reviewed May 15, 2025

View reviewed changes

KoBeWi force-pushed the hover_witch branch 2 times, most recently from 6c9dd11 to bf5d7fa Compare May 15, 2025 19:45

kitbdev reviewed May 15, 2025

View reviewed changes

scene/gui/tab_bar.cpp Outdated Show resolved Hide resolved

scene/gui/tab_bar.cpp Outdated Show resolved Hide resolved

KoBeWi force-pushed the hover_witch branch from bf5d7fa to ebe967e Compare May 16, 2025 13:22

kitbdev requested changes May 16, 2025

View reviewed changes

kitbdev reviewed May 16, 2025

View reviewed changes

scene/gui/tab_bar.h Outdated Show resolved Hide resolved

KoBeWi force-pushed the hover_witch branch from ebe967e to 8e7de2f Compare May 17, 2025 21:28

KoBeWi requested a review from a team as a code owner May 17, 2025 21:28

KoBeWi force-pushed the hover_witch branch from 8e7de2f to 1d24496 Compare June 4, 2025 12:57

KoBeWi requested a review from kitbdev June 4, 2025 12:57

KoBeWi force-pushed the hover_witch branch from 1d24496 to 7f09626 Compare September 16, 2025 18:28

KoBeWi force-pushed the hover_witch branch from 7f09626 to d7beca9 Compare September 18, 2025 20:19

YeldhamDev approved these changes Sep 22, 2025

View reviewed changes

KoBeWi force-pushed the hover_witch branch from d7beca9 to 0cfdc23 Compare September 22, 2025 14:32

kitbdev modified the milestones: 4.x, 4.6 Sep 24, 2025

kitbdev approved these changes Sep 24, 2025

View reviewed changes

kitbdev mentioned this pull request Sep 26, 2025

Rework editor docks #106503

Merged

This comment was marked as resolved.

Sign in to view

KoBeWi force-pushed the hover_witch branch from 0cfdc23 to 7453950 Compare October 3, 2025 21:29

Repiteo requested changes Oct 21, 2025

View reviewed changes

scene/gui/tab_bar.h Show resolved Hide resolved

scene/gui/tab_bar.cpp Show resolved Hide resolved

YeldhamDev reviewed Oct 21, 2025

View reviewed changes

scene/gui/tab_bar.cpp Outdated Show resolved Hide resolved

KoBeWi force-pushed the hover_witch branch from 7453950 to 4ce3262 Compare October 21, 2025 20:56

Add switch on hover to TabBar

682b0f7

KoBeWi force-pushed the hover_witch branch from 4ce3262 to 682b0f7 Compare October 21, 2025 22:35

Repiteo approved these changes Oct 22, 2025

View reviewed changes

Repiteo merged commit 8191042 into godotengine:master Oct 22, 2025
20 checks passed

KoBeWi deleted the hover_witch branch October 22, 2025 00:52

Uh oh!

Conversation

KoBeWi commented Mar 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Calinou left a comment

Choose a reason for hiding this comment

Uh oh!

KoBeWi commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kitbdev left a comment

Choose a reason for hiding this comment

Uh oh!

kitbdev May 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KoBeWi commented May 16, 2025

Uh oh!

kitbdev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kitbdev May 16, 2025

Choose a reason for hiding this comment

Uh oh!

KoBeWi May 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kitbdev commented May 16, 2025

Uh oh!

KoBeWi commented May 17, 2025

Uh oh!

YeldhamDev commented Sep 16, 2025

Uh oh!

KoBeWi commented Sep 18, 2025

Uh oh!

YeldhamDev commented Sep 18, 2025

Uh oh!

KoBeWi commented Sep 18, 2025

Uh oh!

YeldhamDev commented Sep 18, 2025

Uh oh!

KoBeWi commented Sep 18, 2025

Uh oh!

YeldhamDev left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Repiteo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Repiteo commented Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

KoBeWi commented Mar 2, 2025 •

edited

Loading

KoBeWi commented Mar 4, 2025 •

edited

Loading

kitbdev left a comment •

edited

Loading