Tweak high-end mark in the visual shader editor's node creation dialog#103340
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 18, 2025
Merged
Conversation
Calinou
commented
Feb 27, 2025
Comment on lines
-547
to
-552
|
|
||
| if (p_config.dark_theme) { | ||
| p_theme->set_color("highend_color", EditorStringName(Editor), Color(1.0, 0.0, 0.0)); | ||
| } else { | ||
| p_theme->set_color("highend_color", EditorStringName(Editor), Color::hex(0xad1128ff)); | ||
| } |
Member
Author
There was a problem hiding this comment.
This color isn't used anywhere else, so it was removed.
KoBeWi
reviewed
Feb 27, 2025
KoBeWi
approved these changes
Feb 27, 2025
Calinou
force-pushed
the
editor-visualshader-tweak-highend-label
branch
from
514abf0 to
8233bab
Compare
Contributor
|
Needs rebase |
paddy-exe
approved these changes
Sep 19, 2025
Member
Author
|
Rebased and tested again, it works as expected. Here's what it looks like with the new editor theme:
|
Calinou
force-pushed
the
editor-visualshader-tweak-highend-label
branch
from
8233bab to
851c47e
Compare
- Use Forward+/Mobile terminology as support actually depends on the rendering method used, not the rendering driver. - Use a standard warning color as this is no longer indicated as Vulkan-specific. - Fix color on light theme (the text was being modulated instead of having its color overridden).
Calinou
force-pushed
the
editor-visualshader-tweak-highend-label
branch
from
851c47e to
8a22dba
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview
Dark theme
Light theme