Add ability to add new EditorSettings shortcuts#102889
Add ability to add new EditorSettings shortcuts#102889Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
0287cc3 to
bfbaba7
Compare
bfbaba7 to
84acd41
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
I see there is some mixup here. Are the new methods supposed to handle only custom shortcuts, or all shortcuts? If the former, the built-in actions in |
Personally, I'm in favor of allowing the user to do whatever they want, in the same vein of them being able to remove any UI element in the editor. An example may be someone creates a custom |
229c15f to
5d526e1
Compare
editor/settings/editor_settings.cpp
Outdated
| List<String> shortcut_list; | ||
| get_shortcut_list(&shortcut_list); | ||
| Vector<String> ret; | ||
| while (shortcut_list.size()) { |
There was a problem hiding this comment.
You should use range iterator instead.
4da2a8e to
2e277c6
Compare
|
Feedback addressed. |
|
Is this planned for 4.6? |
Co-Authored-By: Igor Kordiukiewicz <igorkordiukiewicz@gmail.com>
2e277c6 to
8806036
Compare
|
Thanks! |
Salvages: #58585
Closes godotengine/godot-proposals#4112.
Closes godotengine/godot-proposals#2024.
Related: godotengine/godot-proposals#11424 (comment)
Address the comments in the salvaged PR, fixed the shortcut name being blank in the editor setting shortcut tree, and other minor modifications.