Add shortcuts to reset position, rotation and scale in Spatial and Canvas Item Editor#102888
Conversation
|
Closes godotengine/godot-proposals#10612 Godot seems to have a little bit of identity crisis where it can't decide if it wants to be blender (G/R/S) (see #78148) or industry-compatible (the current W/E/R), I guess when that's resolved these shortcuts should conform to whatever is considered to be the primary way. For now it's still W/E/R so no changes are needed to this PR |
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally, it mostly works as expected (including undo/redo). Code looks good to me.
I noticed two issues though:
- In 3D, the shortcut should be ignored if currently in freelook, as holding Alt (for slow movement) and pressing W (to move forward on QWERTY) will reset the selected node's position.
- In 2D, resetting position/rotation/scale only works on nodes that inherit Node2D, not Control.
Shaderd00d
force-pushed
the
clear_transform
branch
from
bcd4251 to
8fe4200
Compare
|
Thanks @Calinou, I've updated the code.
|
akien-mga
changed the title
|
Could you squash the commits? See PR workflow for instructions. |
Shaderd00d
force-pushed
the
clear_transform
branch
from
1c0502b to
ac9d39d
Compare
Done. Thanks for the hint. |
|
Could you rebase your PR? It'll use the same pull request guidelines mentioned earlier, though it's now hosted on a new site |
|
@Repiteo I'll take care of it, but it may take a few days. |
Shaderd00d
force-pushed
the
clear_transform
branch
from
ac9d39d to
0d2d527
Compare
Shaderd00d
force-pushed
the
clear_transform
branch
from
48aa05d to
2aec295
Compare
|
@Repiteo I believe this PR is now ready to be merged. |
|
Thanks! Congratulations on your first merged contribution! 🎉 |
8 participants
These changes allow resetting Node3D and Node2D transforms in the Spatial and Canvas Item Editor according to proposal #11523.
The keybindings default to ALT+W (position), ALT+E (rotation) and ALT+R (scale) and thus align with the default bindings to activate Move Mode (W), Rotate Mode (E) and Scale Mode (R).
Either a single selected node or multiple selected nodes can be reset and the reset can be undone.
The keybindings can be changed under Editor Settings -> Shortcuts.
