Show file when FileSystem is searched with UID#102789
Show file when FileSystem is searched with UID#102789akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
|
Is there a reason this didn't make it into 4.5, given #99094 landed and this complements that UX? I’ve cherry-picked it into my build, and it still works well, would love to see it in 4.5.1. |
|
It was likely overlooked. I forgot I made this tbh 😅 |
34e2782 to
8a2c30e
Compare
|
It feels a bit overly specific that you have to enter the exact UID of a given resource. I'd personally expect the search to find the resource based on early matches. For example, writing On one hand, I understand. This process may potentially be too slow, as the string representation is not how UIDs are stored. It doesn't help that, in this PR, an invalid UID causes the search to silently fail, with no way of knowing. A typical file search would at least show no file matches in the results, but because this PR navigates to the file result, nothing happens. |
Well, this feature does expect it. It's meant for quick lookup, currently there is no way to do that, other than using EditorScript.
If nothing gets selected, I think it's enough indicator that the UID is not found 🤔 |
|
I think quick lookup would be better as a commandclick on the string itself. For now it opens the resource on the right side it could easily focus it on fileSystem at the same time. I feel like the search bar is not the right place for it as it used otherwise as a filter not a quick lookup. I would prefer something like partial match with filtering on that meaning you would only see the ones that have uids corresponding. But I see how this could be a nightmare as there is a mix of string and ints Edit : I just realised there is a button for just that in the tooltip then I4m wondering when you would have the uid ready to copy but not have access to the tooltip? |
That only works in script editor. What about Output or UIDs copied from external sources? (e.g. a history file from a plugin) |
|
Is any chance this PR will be in 4.6? I've seen some progression about the caching and storing the UIDs |
|
Thanks! |
Closes godotengine/godot-proposals#10737
Entering a UID in FileSystem's filter will navigate to that UID:
godot.windows.editor.dev.x86_64_qxMh0V1SCE.mp4
At first I wanted to search the file, but the dock does not support finding by full path.