Minimize some editor panels to prevent GUI overflow#102301
Minimize some editor panels to prevent GUI overflow#102301arkology wants to merge 1 commit intogodotengine:masterfrom
Conversation
| bus_scroll->set_v_size_flags(SIZE_EXPAND_FILL); | ||
| bus_scroll->set_vertical_scroll_mode(ScrollContainer::SCROLL_MODE_DISABLED); | ||
| bus_scroll->set_custom_minimum_size(Size2(0, 200) * EDSCALE); | ||
| bus_scroll->set_size(Size2(0, 350) * EDSCALE); |
There was a problem hiding this comment.
I don't think set_size() has any effect here.
Minimizing the editor panels should not affect editor at full size. We need a better sizing mechanism before doing such changes.
There was a problem hiding this comment.
I think I have an idea about it. I will try it and then write the results here.
|
This makes some editors too small by default (as noted above). Unfortunately we don't have "preferred size" and things usually shrink to minimum size. Trying to set default size won't have effect. I encountered the same problem while trying to resolve #26392 (by making minimum size smaller, with default being the same as now) and there is just no solution right now. |
|
Thanks for review! Some findings (for Tilemap/TileSet editors, for example) may be still valid and I will move them to another PR. |
|
In Network Profiler the Up label should be together with the following field. |
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally (rebased on top of master b607110), it works as expected.
However, there's the issue that the Audio bottom panel now looks like this when you first open it, regardless of the window height:
We should try to use a "suggested" height on a best-effort basis where you can see the whole thing, and only see a smaller height if we physically can't fit it within the editor window without overflowing.
I'm not sure if the concept of default/suggested height should be present at a (Split)Container level, or just specific to the editor. Many non-game applications made with Godot run into similar issues in my experience, so they end up having to add some bespoke code for it.
This is the smallest possible height without a visible scroll bar:
(Sometimes, I wonder if we could redesign the Audio bottom panel to use an horizontal layout, but this would come with its own caveats when working with a lot of buses.)
How about queue disabling/enabling vertical scroll when the Audio bottom panel becomes visible/hidden ? will try to see if this can fix the issue. Edit: This may not work unless we find a way to reset the |
Note for Godot team members: No need to review this PR, I split it into individual PRs linked above (not everything is done at the moment, but most of the work has already been done.) |
4 participants
Alternative to #101828.
Same as linked PR, may fix #26835 and fix #96479.
Aslo includes #102024 for now
I looked at (almost) every panel which could affect horizontal or vertical overflow when window size is minimal and did some tweaks of minimal size or another changes to minimize panel size (for example, use
FlowContainerinstead ofBoxContainer, enableScrollContainerscrolling).For now only missing editor panel is
AnimationTree(WIP). But I may overlooked another panels.Also includes some concomitant changes like enabling
Labelword wrapping and fixing C++ C26819 warning (this could be reverted if not wanted).May include some improper changes, so any suggestions are very appreciated. Also, it may look different than it does on my end, and therefore not fix the overflow, so it needs testing.
It could be split into several PRs if needed and changes are accepted.
AnimationPlayertab (vertical overflow)Audiotab (vertical overflow)AnimationTreetab (vertical overflow, WIP)BlendSpace1D(vertical overflow)BlendSpace2D(horizontal and vertical overflow, WIP)Polygon2DEditor(horizontal and vertical overflow)Shader Editor(vertical overflow)ShaderFile(vertical overflow)SpriteFrames(vertical overflow)ThemeEditor(horizontal and vertical overflow)EditorNetworkProfiler(vertical overflow)