Separate Node editor dock#101787
Conversation
0c4ecf0 to
a690020
Compare
Mickeon
left a comment
There was a problem hiding this comment.
As is, the current PR breaks compatibility with feature profiles because of the removal of FEATURE_NODE_DOCK and the two new features added in the middle. The FEATURE_NODE_DOCK constant should at least be marked as deprecated. But it would also no longer do anything, which is likely not desired...
a690020 to
aea7e83
Compare
aea7e83 to
05ec561
Compare
|
There were many merge conflicts with this PR, so I rewrote it from scratch, and it's now back to its previous functional state. To reiterate, this PR is fully functional. The only unresolved concern I had was allowing it to work with feature profiles without breaking compatibility. My current solution, as shown in my last comment, simply marks the Node dock option as deprecated and adds the 2 new docks to the bottom of the list. With all the other UI changes in 4.6, I would love to get this merged in time! Also, apologies for leaving this PR dormant for so long - seemingly whenever I had free time, there was a feature freeze |
|
Tested, works as expected and makes sense |
|
I'll reopen this PR now in case the current deprecation approach is acceptable, but I'm still happy to implement an alternative |
|
The Group dock is not properly disabled when a Resource is selected and prints errors when toggling groups. |
5a7896d to
e2b3e52
Compare
|
Thank you all for the reviews! I believe it should be all good now |
|
This seems like a net positive to me. It feels weird to have these views in tabs named "Signals" and "Groups" because now you don't have the context of them being properties of the selected Node. On the other hand I think it's weirder that we had multiple levels of tabs. At one point I had an editor layout saved with the Node tab open and focused on "Groups" which led to some confusion in the past whenever I loaded that layout. Because I don't use groups, this change means I can just close the Groups tab and remove some of the clutter. I do worry that this could create too many top-level tabs though. Right now I have Inspector, Node, Import, History as the four tabs in my right pane. This change would increase that to 5 were I to not close the Groups tab. |
|
This also sounds good to me. It does make me wonder if the "Inspector" tab should be named to something else, like "Properties". The word "Inspector" feels too all-encompassing to me, for something that only allows you to inspect some aspects of a selected item, while other aspects are in separate tabs with more precise names. That being said, the term "Inspector" is no doubt used in lots of tutorials and resources, so changing it could cause confusion for newcomers... |
|
In my heart I want all the inspecting to happen in the inspector, but I can't find a way to argue with the logic of the separate docks, it just makes more sense. The inspector has a slightly odd name, but that uniqueness helps make references to it clear and unambiguous. "Properties" is a technical term, it already refers to a separate idea. "Change the property in the inspector" makes more sense than "change the property in the properties". People would need to call it "the properties tab" for clarity. It's a more accurate description, but a less useful name. |
e2b3e52 to
ba6d9c3
Compare
|
Fixed the new merge conflicts. Not exactly sure why the Also, to touch on the reasoning, I understand that having an extra dock will take up more space, but I believe its benefits outweigh this, e.g.
|
The label was moved to Signals and Groups tabs separately, because they have different messages. If they were to be covered by single message, it'd need to be something like "Select a single node to edit its signals or one or multiple nodes to edit their groups, or select an independent resource to view its signals.". Totally incomprehensible. |
|
Needs rebase |
ba6d9c3 to
ef97380
Compare
|
Thanks! Congratulations on your first merged contribution! 🎉 |
|
Is it intended, that the Signal panel works with resources after this PR? I don't see it mentioned in the PR description. |
|
That's from #109043 |
|
Alright thanks! Does this count under the new theme tracker or is this a separate thing? Because I feel like this addition really requires disambiguation in the dock about which object is currently viewed (similar to how the inspector shows the object in its header). Right now there is no way to tell what the panel is even looking at. |
|
The dock changes aren't related to the new theme.
That's more or less the same as before, just the tabs were moved. The inspector always matches the signal/group docks. |

Closes godotengine/godot-proposals#11590
Fixes #103033
Alternative PR: #101584
Also related to godotengine/godot-proposals#9052 and godotengine/godot-proposals#9448
Separated the Node editor dock into a Signals editor dock and a Groups editor dock (justification in the linked proposal).
Before:


After:
Thanks :)