Merged
Conversation
Contributor
|
#101341 :)
|
arkology
reviewed
Jan 9, 2025
Contributor
|
Interesting, is it possible to do the same without adding new variable? |
Member
Author
|
Yes, but it involves rounding the size every time you want to use it. I think it's better to do it once.
It doesn't print any errors and has no conditional behavior. Seems fine as is. |
arkology
reviewed
Jan 9, 2025
KoBeWi
force-pushed
the
roundabout_solution
branch
from
a1fdc43 to
4c5a495
Compare
Contributor
|
I just wonder if |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101341
The image size uses integer vector, so the region needed some special handling. There are various solutions, I went with adding a second Rect2 with rounded size. Keeping the original float value makes the property editing more intuitive (because Rect2 size is edited as float vector) and works better with region editor.