X Tutup
Skip to content

Remove prompt to restart editor after changing custom theme#100876

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
Open-Industry-Project:no-restart-prompt-custom-theme
Sep 23, 2025
Merged

Remove prompt to restart editor after changing custom theme#100876
Repiteo merged 1 commit intogodotengine:masterfrom
Open-Industry-Project:no-restart-prompt-custom-theme

Conversation

@ryevdokimov
Copy link
Contributor

I don't believe this is required anymore.

Tested with: https://github.com/passivestar/godot-minimal-theme

2024-12-28.13-15-46.mp4

@passivestar
Copy link
Contributor

I compared pre/post restart screenshots with both minimal theme 2.x and 1.x and couldn't spot any difference so it seems like restart is indeed not required

@ryevdokimov ryevdokimov force-pushed the no-restart-prompt-custom-theme branch from 7919351 to fc7b757 Compare July 8, 2025 19:01
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with https://github.com/passivestar/godot-minimal-theme, it works as expected. The theme's display is 100% identical before and after a restart as far as I can tell.

@Repiteo Repiteo modified the milestones: 4.x, 4.6 Sep 23, 2025
@Repiteo Repiteo merged commit 2455635 into godotengine:master Sep 23, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 23, 2025

Thanks!

@ryevdokimov ryevdokimov deleted the no-restart-prompt-custom-theme branch September 23, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

X Tutup