Fix ProjectManager import dialog error#100197
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 5, 2025
Merged
Conversation
fire
changed the title
Member
|
This code was introduced in #95062, so this would be a regression / bug introduced in 4.3. |
akien-mga
added
regression
cherrypick:4.3
Member
|
Canceling should go back to Create New Project dialog, now it closes it completly. godot.windows.editor.dev.x86_64_fyFDn8BofZ.mp4vs godot_Ly3jxXOmwG.mp4 |
Repiteo
added
the
cherrypick:4.4
akien-mga
added
needs work
and removed
cherrypick:4.3
shitake2333
force-pushed
the
fix_project_manager_import_dialog_error
branch
from
c7b02c7 to
427cffb
Compare
Contributor
Author
|
Sorry, I forgot about this PR for a while. I've fixed the commit. It's working correctly now! |
KoBeWi
approved these changes
Nov 3, 2025
When Cancel is selected in the import dialog, no subsequent operations should be performed.
shitake2333
force-pushed
the
fix_project_manager_import_dialog_error
branch
from
427cffb to
39fbcbd
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Cancel is selected in the import dialog, no subsequent operations should be performed.
The signal in the original code was incorrectly connected to
canceledinstead ofconfirmed. This results in that after canceling the import dialog, subsequent operations are still performed and the default path is used as the path for the imported project.