Update GFile::read_as_gstring_entire() after Godot removes skip_cr parameter#1349
Merged
Yarwin merged 1 commit intogodot-rust:masterfrom Oct 2, 2025
Merged
Conversation
Yarwin
added
bug
c: engine
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1349 |
Contributor
|
Since your edit, the word "polyfill" no longer applies, right? In PR description, commit message, and in code comments. |
Yarwin
force-pushed
the
add-polyfill-for-read-as-gstring-entire
branch
from
d0e593e to
43137a8
Compare
Yarwin
changed the title
read_as_gstring_entire for Godot versions before 4.6.read_as_gstring_entire in Godot versions newer than 4.5.
Yarwin
force-pushed
the
add-polyfill-for-read-as-gstring-entire
branch
from
43137a8 to
94df0b8
Compare
Contributor
Author
Welp, calling it pollyfill was a stretch in a first place 😄 |
Contributor
|
Looks good to me! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
TitanNano
reviewed
Oct 1, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
I will merge it later this day, Github has some issues with MacOS runners: https://www.githubstatus.com/incidents/071h21gptcp0. |
Bromeon
changed the title
read_as_gstring_entire in Godot versions newer than 4.5.GFile::read_as_gstring_entire() after Godot removes skip_cr parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skip_crargument has been removed, see: godotengine/godot#110867.EDIT: Nothing changes for 4.5 API, generated code compatibility is never guaranteed (i.e. generated signatures for API version
4.xmight be different for4.x+1), so after consultation we decided that SemVer bump is not required (from sanity point of view as well – APIs before beta/RCs can be wildly unstable)