Add "Scale (fit)" background image mode#2023
Open
PatchMixolydic wants to merge 1 commit intognunn1:masterfrom
Open
Add "Scale (fit)" background image mode#2023PatchMixolydic wants to merge 1 commit intognunn1:masterfrom
PatchMixolydic wants to merge 1 commit intognunn1:masterfrom
Conversation
Collaborator
|
Can you maybe clean this PR up a bit and remove all the l10n changes and other unrelated changes that are merged in? Having those makes this very hard to review at the moment. |
Author
|
Sorry about that, will do 👍 |
PatchMixolydic
force-pushed
the
master
branch
2 times, most recently
from
52bc4cd to
4e6e7d6
Compare
The current "Scale" mode crops out part of the image if the scaled image is larger than the terminal in any direction. This is useful for most cases, such as wallpapers repurposed as terminal backgrounds. However, this may be surprising to users coming from xfce4-terminal, where the equivalent "Scaled" mode tries to fit the background within the terminal in both dimensions. This new "Scale (fit)" mode is meant to emulate this behaviour.
PatchMixolydic
force-pushed
the
master
branch
from
4e6e7d6 to
c4f504c
Compare
Author
|
I've removed the localization changes and tidied up the scaling code. Please let me know if you'd like me to make any further changes. |
algj
approved these changes
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current "Scale" mode crops out part of the image if the scaled image is larger than the terminal in any direction. This is useful for most cases, such as wallpapers repurposed as terminal backgrounds. However, this may be surprising to users coming from xfce4-terminal, where the equivalent "Scaled" mode tries to fit the background within the terminal in both dimensions. This new "Scale (fit)" mode is meant to emulate this behaviour.
I'm aware that Tilix is currently in low-maintenance mode and looking for a new maintainer, but since this mostly builds off of the "Scale" background image mode, I feel that this addition is fairly minor. Feel free to close this PR if it would carry too much of a maintenance burden.
Here are some examples of the differences between "Scale" and "Scale (fit)" using a typical background and a background well suited to "Scale (fit)":
Typical background, Scale
Typical background, Scale (fit)
Transparent PNG, Scale
Transparent PNG, Scale (fit)