ResponseAccess::current() should be compatible with Iterator::current()#129
Merged
gnikyt merged 1 commit intognikyt:masterfrom Sep 6, 2022
Merged
ResponseAccess::current() should be compatible with Iterator::current()#129gnikyt merged 1 commit intognikyt:masterfrom
gnikyt merged 1 commit intognikyt:masterfrom
Conversation
…rent() I had a few error messages using PHP 8.1 like `Return type of Osiset\BasicShopifyAPI\ResponseAccess::current() should either be compatible with Iterator::current(): mixed` This fixes it :)
|
@osiset Any chance we can get this merged? We're noticing this deprecation error since switching to PHP 8.1. |
Contributor
Author
|
I'm not using it on PHP 8.1 anymore but I think there are more cases I haven't fixed. Feel free to update my PR :) |
|
@osiset any chance this can be merged? |
|
Verified, this PR solves the depreciation issues with php 8.1. Please merge |
Closed
|
@osiset Is there anyone who can marge these changes if you're too busy at the moment? |
|
@osiset Hi is there anything stopping this from being merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
Thanks for this great API!
I had a few error messages using PHP 8.1 like
Return type of Osiset\BasicShopifyAPI\ResponseAccess::current() should either be compatible with Iterator::current(): mixedThis fixes it :)