util: move expand_path from repo/base and use it in Git class init#664
Merged
Byron merged 1 commit intogitpython-developers:masterfrom Sep 28, 2017
Merged
util: move expand_path from repo/base and use it in Git class init#664Byron merged 1 commit intogitpython-developers:masterfrom
Byron merged 1 commit intogitpython-developers:masterfrom
Conversation
Contributor
Author
|
Any chance to get some feedback on this? 🙂 |
Member
|
Thanks a lot for your contribution, and sorry for the late reply. This looks good to me! |
Contributor
Author
|
No worries for the delay, thanks for merging 🙂 |
riley-martine
pushed a commit
to riley-martine/GitPython
that referenced
this pull request
Dec 7, 2023
util: move expand_path from repo/base and use it in Git class init
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting using GitPython, I quickly encountered a surprising behavior: a
Repoinstance could be initialized with a path like~/path/to/some/repobut aGitinstance couldn't. And indeed,Repoexpands the path it is given whileGitdoesn't.This PR is an attempt at fixing this by moving the
_expand_path()method previously defined inrepo/base.pyto andexpand_path()method in theutil/part, and using it both where it was already used and newly in theGitconstructor.