Give Popen a silly buffer size, or you only get the first 2^16 bytes

Owen Smith · Owen Smith · commit e393f85e2fe6 · 2014-05-09T12:49:41.000+01:00
Without this, some commands with large output fail horrible. For example, fetching remotes that have a large ref list: it fetches fine, but then the parsing for FetchInfo dies because the (trimmed) stderr list isn't as long as the list from FETCH_HEAD.

I couldn't find a generic way to make this unbounded (temporary files, for example) without rewriting *everywhere* that stdout/stderr is read. Which is...a lot of places.
diff --git a/git/cmd.py b/git/cmd.py
@@ -338,6 +338,7 @@ def execute(self, command,
                         stderr=PIPE,
                         stdout=PIPE,
                         close_fds=(os.name=='posix'),# unsupported on linux
+                        bufsize=(10 *1024 * 1024),
                         **subprocess_kwargs
                         )
         if as_process:

Original file line number	Diff line number	Diff line change
`@@ -338,6 +338,7 @@ def execute(self, command,`
`338`	`338`	`stderr=PIPE,`
`339`	`339`	`stdout=PIPE,`
`340`	`340`	`close_fds=(os.name=='posix'),# unsupported on linux`
	`341`	`+ bufsize=(10 1024 1024),`
`341`	`342`	`**subprocess_kwargs`
`342`	`343`	`)`
`343`	`344`	`if as_process:`