X Tutup
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: github-lab/npgsql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: dev
Choose a base ref
...
head repository: github-lab/npgsql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: prepared-statements-without-npgsqldbtype
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 5 files changed
  • 1 contributor

Commits on Jun 12, 2018

  1. Fix prepared statements and types with no NpgsqlDbType 

    Npgsql caches prepared statements by their SQL. However, since
PostgreSQL makes use of parameter types when preparing, overloaded SQL
can exist: same SQL, different param types. We don't include the
param types in the cache key for perf reasons (overloaded SQL is very
rare), but we do store them on the prepared statement and make sure
types correspond.

In the previous implementation, param types were stored as an array
of NpgsqlDbType. However, we have types where there's no NpgsqlDbType:
enums, composites, and in theory extension types that can be selected
via the new DataTypeName, but have no NpgsqlDbType.

Changed the param types to be represented as a list of type handler
types.

Fixes npgsql#1987
    @roji
    roji committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    4babcb0 View commit details
    Browse the repository at this point in the history
Loading
X Tutup