X Tutup
Skip to content

Bump undici to at least 6.24.0#3785

Open
mbg wants to merge 1 commit intomainfrom
mbg/dep/update-undici
Open

Bump undici to at least 6.24.0#3785
mbg wants to merge 1 commit intomainfrom
mbg/dep/update-undici

Conversation

@mbg
Copy link
Copy Markdown
Member

@mbg mbg commented Mar 27, 2026

Updates undici to at least version 6.24.0.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Advanced setup - Impacts users who have custom CodeQL workflows.
  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • Other first-party - The changes impact other first-party analyses.
  • Third-party analyses - The changes affect the upload-sarif action.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
  • GHES - Impacts CodeQL workflows on GitHub Enterprise Server.
  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg self-assigned this Mar 27, 2026
@github-actions github-actions bot added the size/XS Should be very easy to review label Mar 27, 2026
@mbg mbg marked this pull request as ready for review March 27, 2026 17:53
Copilot AI review requested due to automatic review settings March 27, 2026 17:53
@mbg mbg requested a review from a team as a code owner March 27, 2026 17:53
redsun82
redsun82 previously approved these changes Mar 30, 2026
@redsun82 redsun82 dismissed their stale review March 30, 2026 10:26

let's see what happened with the large scale experiment on this, removing the approval to avoid accidental merge before we have that data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup