-
Notifications
You must be signed in to change notification settings - Fork 7
Comparing changes
Open a pull request
base repository: renozao/RcppOctave
base: master
head repository: git-steb/RcppOctave
compare: master
- 13 commits
- 52 files changed
- 1 contributor
Commits on May 10, 2017
-
Added Octave header signal-wrapper.h
- Allows to access some internal Octave functions
Configuration menu - View commit details
-
Copy full SHA for 592afcd - Browse repository at this point
Copy the full SHA 592afcdView commit details -
Octave compatibility update (v3.8.2, v4.0.2, v4.2.1, v4.3.0+)
Fixed compilation issue with Octave 4.0.2 (undefined OCTINTERP_API) - Addressing build error: ‘OCTINTERP_API’ does not name a type - inserted #include <octave/config.h> in swig_octave_version.h Working towards ocave 4.3.0+ compatibility - Bug with current octave_main start of embedded interpreter, when determining loadpath during interpreter initialization, the interpreter of the global octave app is required, but not yet initialized raising exception about missing context. Octave 4.3.0+ compatibility update "0+" patch version issues: - changed SWIG_OCTAVE_PREREQ version check macro to ignore patch version "0+", to workaround C preprocessor errors - override R's utils::compareVersion function in R/utils.R Octave interpreter startup API update: - creating octave::cli_application before calling octave_main to resolve problem of missing global octave application, when creating an embedded octave interpreter. This is due to an Octave API update. compatibility for Octave version >= 4.0 < 4.3 - octave/config.h has to be included before octave/version.h for a certain range of octave versions Octave 3.8.2 compatibility more compatibility for R 3.8.2 and beyond Octave 4.3.0+ works - Creation of an embedded interpreter in this version of Octave is a bit strange, working around a possible bug in the not yet released version 4.3.0 - An octave::cli_application has to be created first, and its interpreter then created and initialized, then a separate embedded interpreter can be produced and executed without waiting for a command prompt. see src/rcpp_octave.cpp - Creating an embedded interpreter without an application results in an exception when determining the load path. Octave 4.2.1 works, too (with 3 new workarounds) - octave_main cannot be used anymore to create the interpreter, the embedded application is destructed upon exit from that function, deleting the interpreter, which sets the global variable octave::current_evaluator to NULL and causes SEGFAULT in feval. resolved by creating embedded_application* inside rcpp_octave.cpp - octave.cc (v4.2, 4.3+) cmdline_options::cmdline_options() uses argv + octave_optind_wrapper(), where argv is the char** produced in rcpp_octave.cpp octave_session and optind is a global int giving the number of arguments getopt.h reports for the executable, having nothing to do with the args produced here. If the executable was called with more than narg arguments, this gives a SEGFAULT. resolved: octave_session now ensures that char** is long enough - upon exit, unloading the symbols, the destructor of octave::symbol_table erases invalid octave_user_function handles, resulting in SIGBUS. Resolved by triggering cleanup earlier in octave_session. Octave 4.3.0+ does not have this problem anymore.
Configuration menu - View commit details
-
Copy full SHA for f702255 - Browse repository at this point
Copy the full SHA f702255View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96980f7 - Browse repository at this point
Copy the full SHA 96980f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 910c1ff - Browse repository at this point
Copy the full SHA 910c1ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for f547c12 - Browse repository at this point
Copy the full SHA f547c12View commit details -
Unit tests passing (R 3.4.0, Octave 4.2.1)
- Octave error messages are passed on with more detail info - updated Octave error message string verification in 3 unit tests - changed rcpp(...) call to cxxfunction(...) call in interface.R - added 'inline' to list of required packages in DESCRIPTION
Configuration menu - View commit details
-
Copy full SHA for 2ba09fe - Browse repository at this point
Copy the full SHA 2ba09feView commit details -
Removed exectution_exception from wording of error message
- removed qlibrary('inline') from unit test, due to missing pkgmaker exportConfiguration menu - View commit details
-
Copy full SHA for 0caf151 - Browse repository at this point
Copy the full SHA 0caf151View commit details
Commits on May 11, 2017
-
Configuration menu - View commit details
-
Copy full SHA for f0f6c56 - Browse repository at this point
Copy the full SHA f0f6c56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2246d38 - Browse repository at this point
Copy the full SHA 2246d38View commit details
Commits on May 23, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 7c9b4c0 - Browse repository at this point
Copy the full SHA 7c9b4c0View commit details
Commits on May 24, 2017
-
Attempt to use Dockerfile for Travis build
- Docker container tags must be lower-case - Run build command inside the container only
Configuration menu - View commit details
-
Copy full SHA for 2521703 - Browse repository at this point
Copy the full SHA 2521703View commit details -
Complete Docker setup for Octaves 3.8 4.0 4.2
- .travis.yml updated to perform builds using layered docker containers - base image created using docker hub account docsteb: docker build dockerfiles/trusty-r-texlive -t docsteb/trusty-r-texlive docker push docsteb/trusty-r-texlive - different Octave installations are layers on top of base image, e.g. docker build -f dockerfiles/octave4.2/Dockerfile . - Octave 4.2 requires extra packages for linking: The packages added to dockerfiles/octave4.2/Dockerfile should probably have been brought in automatically when installing liboctave4.2-dev from ppa:kwwette/octaves - built tar.gz package file is copied out of the builder container once completed
Configuration menu - View commit details
-
Copy full SHA for 2e0fb08 - Browse repository at this point
Copy the full SHA 2e0fb08View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9edbeb - Browse repository at this point
Copy the full SHA e9edbebView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master