X Tutup
Skip to content

style: Auto changes made from "yarn fix"#19710

Merged
JPeer264 merged 1 commit intodevelopfrom
jp/fix-lint
Mar 10, 2026
Merged

style: Auto changes made from "yarn fix"#19710
JPeer264 merged 1 commit intodevelopfrom
jp/fix-lint

Conversation

@JPeer264
Copy link
Member

@JPeer264 JPeer264 commented Mar 9, 2026 •
edited by github-actions bot
Loading

I ran yarn fix on develop and there was a change.

Does that mean that the CI doesn't fail when the files are not formatted correctly?!

Closes #19711 (added automatically)

@JPeer264 JPeer264 self-assigned this Mar 9, 2026
@github-actions github-actions bot mentioned this pull request Mar 9, 2026
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026 •
edited
Loading

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 25.64 kB +0.05% +12 B 🔺
@sentry/browser - with treeshaking flags 24.14 kB +0.03% +7 B 🔺
@sentry/browser (incl. Tracing) 42.44 kB +0.02% +8 B 🔺
@sentry/browser (incl. Tracing, Profiling) 47.1 kB +0.02% +8 B 🔺
@sentry/browser (incl. Tracing, Replay) 81.26 kB +0.02% +9 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 70.88 kB +0.02% +8 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 85.95 kB +0.02% +9 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 98.21 kB +0.01% +7 B 🔺
@sentry/browser (incl. Feedback) 42.44 kB +0.02% +7 B 🔺
@sentry/browser (incl. sendFeedback) 30.31 kB +0.04% +11 B 🔺
@sentry/browser (incl. FeedbackAsync) 35.36 kB +0.04% +11 B 🔺
@sentry/browser (incl. Metrics) 26.8 kB +0.04% +9 B 🔺
@sentry/browser (incl. Logs) 26.95 kB +0.03% +8 B 🔺
@sentry/browser (incl. Metrics & Logs) 27.62 kB +0.04% +9 B 🔺
@sentry/react 27.39 kB +0.04% +9 B 🔺
@sentry/react (incl. Tracing) 44.78 kB +0.02% +8 B 🔺
@sentry/vue 30.09 kB +0.04% +10 B 🔺
@sentry/vue (incl. Tracing) 44.31 kB +0.03% +9 B 🔺
@sentry/svelte 25.66 kB +0.04% +9 B 🔺
CDN Bundle 28.18 kB +0.04% +9 B 🔺
CDN Bundle (incl. Tracing) 43.27 kB +0.03% +11 B 🔺
CDN Bundle (incl. Logs, Metrics) 29.02 kB +0.04% +9 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) 44.11 kB +0.03% +10 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 68.1 kB +0.02% +8 B 🔺
CDN Bundle (incl. Tracing, Replay) 80.15 kB +0.02% +12 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 81.01 kB +0.02% +10 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 85.66 kB +0.02% +9 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 86.54 kB +0.02% +10 B 🔺
CDN Bundle - uncompressed 82.38 kB +0.04% +26 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 128.09 kB +0.03% +26 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 85.21 kB +0.04% +26 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 130.93 kB +0.02% +26 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 208.88 kB +0.02% +26 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 244.98 kB +0.02% +26 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 247.8 kB +0.02% +26 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 257.89 kB +0.02% +26 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 260.7 kB +0.01% +26 B 🔺
@sentry/nextjs (client) 47.19 kB +0.02% +9 B 🔺
@sentry/sveltekit (client) 42.9 kB +0.02% +8 B 🔺
@sentry/node-core 52.27 kB +0.07% +33 B 🔺
@sentry/node 174.77 kB +0.04% +62 B 🔺
@sentry/node - without tracing 97.44 kB +0.06% +53 B 🔺
@sentry/aws-serverless 113.24 kB +0.05% +49 B 🔺

View base workflow run

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026 •
edited
Loading

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 11,233 - 9,389 +20%
GET With Sentry 1,987 18% 1,709 +16%
GET With Sentry (error only) 7,485 67% 6,041 +24%
POST Baseline 1,149 - 1,208 -5%
POST With Sentry 585 51% 589 -1%
POST With Sentry (error only) 1,024 89% 1,065 -4%
MYSQL Baseline 3,947 - 3,242 +22%
MYSQL With Sentry 533 14% 436 +22%
MYSQL With Sentry (error only) 3,236 82% 2,650 +22%

View base workflow run

Lms24
Lms24 approved these changes Mar 9, 2026
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean that the CI doesn't fail when the files are not formatted correctly?!

Hmm looks like it. OR it's a violation that's auto-fixable but only produces a warning? @logaretm any ideas?

I can confirm I get the same modification when I run yarn fix locally

@logaretm
Copy link
Member

logaretm commented Mar 9, 2026

@Lms24 @JPeer264 Yep this was a warning, I had planned to take care of most of them this week. But looks like this is the only auto fixable one.

CleanShot 2026-03-09 at 09 39 33

@JPeer264 JPeer264 enabled auto-merge (squash) March 10, 2026 09:33
@JPeer264 JPeer264 merged commit 29bb118 into develop Mar 10, 2026
441 of 443 checks passed
@JPeer264 JPeer264 deleted the jp/fix-lint branch March 10, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@logaretm logaretm logaretm approved these changes

@Lms24 Lms24 Lms24 approved these changes

@andreiborza andreiborza Awaiting requested review from andreiborza

Assignees

@JPeer264 JPeer264

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

style: Auto changes made from "yarn fix"

3 participants

@JPeer264 @logaretm @Lms24
X Tutup