forked from danmar/cppcheck
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathtestcharvar.cpp
More file actions
176 lines (149 loc) · 4.85 KB
/
testcharvar.cpp
File metadata and controls
176 lines (149 loc) · 4.85 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
/*
* Cppcheck - A tool for static C/C++ code analysis
* Copyright (C) 2007-2011 Daniel Marjamäki and Cppcheck team.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "tokenize.h"
#include "checkother.h"
#include "testsuite.h"
#include <sstream>
extern std::ostringstream errout;
class TestCharVar : public TestFixture {
public:
TestCharVar() : TestFixture("TestCharVar")
{ }
private:
void run() {
TEST_CASE(array_index_1);
TEST_CASE(array_index_2);
TEST_CASE(bitop1);
TEST_CASE(bitop2);
TEST_CASE(return1);
TEST_CASE(assignChar);
TEST_CASE(and03);
TEST_CASE(pointer);
}
void check(const char code[]) {
// Clear the error buffer..
errout.str("");
Settings settings;
settings.addEnabled("style");
// Tokenize..
Tokenizer tokenizer(&settings, this);
std::istringstream istr(code);
tokenizer.tokenize(istr, "test.cpp");
tokenizer.setVarId();
// Check char variable usage..
CheckOther checkOther(&tokenizer, &settings, this);
checkOther.checkCharVariable();
}
void array_index_1() {
check("void foo()\n"
"{\n"
" unsigned char ch = 0x80;\n"
" buf[ch] = 0;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
check("void foo()\n"
"{\n"
" char ch = 0x80;\n"
" buf[ch] = 0;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (warning) Using char type as array index\n", errout.str());
check("void foo()\n"
"{\n"
" signed char ch = 0x80;\n"
" buf[ch] = 0;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (warning) Using char type as array index\n", errout.str());
check("void foo(char ch)\n"
"{\n"
" buf[ch] = 0;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:3]: (warning) Using char type as array index\n", errout.str());
check("void foo(const char str[])\n"
"{\n"
" map[str] = 0;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
}
void array_index_2() {
// #3282 - False positive
check("void foo(char i);\n"
"void bar(int i) {\n"
" const char *s = \"abcde\";\n"
" foo(s[i]);\n"
"}");
ASSERT_EQUALS("", errout.str());
}
void bitop1() {
check("void foo()\n"
"{\n"
" int result = 0;\n"
" char ch;\n"
" result = a | ch;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (warning) When using char variables in bit operations, sign extension can generate unexpected results.\n", errout.str());
}
void bitop2() {
check("void foo()\n"
"{\n"
" char ch;\n"
" func(&ch);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
}
void return1() {
check("void foo()\n"
"{\n"
" char c;\n"
" return &c;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
}
void assignChar() {
check("void foo()\n"
"{\n"
" char c;\n"
" c = c & 0x123;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
}
void and03() {
check("void foo()\n"
"{\n"
" char c;\n"
" int i = c & 0x03;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
}
void pointer() {
// ticket #2866
check("void f(char *p) {\n"
" int ret = 0;\n"
" ret |= *p;\n"
" return ret;\n"
"}");
ASSERT_EQUALS("[test.cpp:2]: (warning) When using char variables in bit operations, sign extension can generate unexpected results.\n", errout.str());
// fixed code
check("void f(char *p) {\n"
" int ret = 0;\n"
" ret |= (unsigned char)*p;\n"
" return ret;\n"
"}");
ASSERT_EQUALS("", errout.str());
}
};
REGISTER_TEST(TestCharVar)