Add function support for py-files dependency management#77
Draft
sarasavilli-sf wants to merge 3 commits intomainfrom
Draft
Add function support for py-files dependency management#77sarasavilli-sf wants to merge 3 commits intomainfrom
sarasavilli-sf wants to merge 3 commits intomainfrom
Conversation
|
|
||
| logger.info(f"Dependencies archived to {DEPENDENCIES_ARCHIVE_PATH}") | ||
| if package_type == "function": | ||
| source_py_files = os.path.join(temp_dir, "py-files") |
| DEPENDENCIES_ARCHIVE_PATH = os.path.join( | ||
| "payload", "archives", DEPENDENCIES_ARCHIVE_FULL_NAME | ||
| ) | ||
| PY_FILES_PATH = os.path.join("payload", "py-files") |
There was a problem hiding this comment.
We need support for libs folder as well? Will you raise a separate PR for the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements py-files based dependency management for function package type:
build_native_dependencies.shto install dependencies directly topy-filesdirectory usingpip install --targetprepare_dependency_archive()to handle both script (tar.gz) and function (py-files) package typesChanges
Core Implementation
prepare_dependency_archive()to acceptpackage_typeparameterzip()to accept package_type as parameterRefactoring
zip()function to CLI layercli.pycommands to detect and pass package_type_get_package_type_for_directory()helper (no longer needed)Tests
Test Plan
package_typeparameterCommits