feat: adjust swap grammar (TheAlgorithms#175)

fireairforce · web-flow · commit b2f6471b8989 · 2020-05-23T11:31:41.000+05:30
* feat: adjust swap grammar

* fix: grammar
diff --git a/Data-Structures/Array/QuickSelect.js b/Data-Structures/Array/QuickSelect.js
@@ -59,9 +59,7 @@ function getRandomInt (min, max) {
 }
 
 function Swap (arr, x, y) {
-  const temp = arr[x]
-  arr[x] = arr[y]
-  arr[y] = temp
+  [arr[x], arr[y]] = [arr[y], arr[x]]
 }
 
 // testing
diff --git a/Sorts/BubbleSort.js b/Sorts/BubbleSort.js
@@ -12,9 +12,7 @@ function bubbleSort (items) {
       // Compare the adjacent positions
       if (items[j] < items[j - 1]) {
         // Swap the numbers
-        const tmp = items[j]
-        items[j] = items[j - 1]
-        items[j - 1] = tmp
+        [items[j], items[j - 1]] = [items[j - 1], items[j]]
       }
     }
   }
@@ -47,9 +45,7 @@ function alternativeBubbleSort (arr) {
     swapped = false
     for (let i = 0; i < arr.length - 1; i++) {
       if (arr[i] > arr[i + 1]) {
-        const temp = arr[i]
-        arr[i] = arr[i + 1]
-        arr[i + 1] = temp
+        [arr[i], arr[i + 1]] = [arr[i + 1], arr[i]]
         swapped = true
       }
     }
diff --git a/Sorts/CocktailShakerSort.js b/Sorts/CocktailShakerSort.js
@@ -7,24 +7,20 @@
 function cocktailShakerSort (items) {
   for (let i = items.length - 1; i > 0; i--) {
     let swapped = false
-    let temp, j
+    let j
 
     // backwards
     for (j = items.length - 1; j > i; j--) {
       if (items[j] < items[j - 1]) {
-        temp = items[j]
-        items[j] = items[j - 1]
-        items[j - 1] = temp
+        [items[j], items[j - 1]] = [items[j - 1], items[j]]
         swapped = true
       }
     }
 
     // forwards
     for (j = 0; j < i; j++) {
       if (items[j] > items[j + 1]) {
-        temp = items[j]
-        items[j] = items[j + 1]
-        items[j + 1] = temp
+        [items[j], items[j + 1]] = [items[j + 1], items[j]]
         swapped = true
       }
     }
diff --git a/Sorts/CombSort.js b/Sorts/CombSort.js
@@ -33,9 +33,7 @@ function combSort (list) {
 
     while (gap + i < list.length) {
       if (list[i] > list[i + gap]) {
-        const value = list[i]
-        list[i] = list[i + gap]
-        list[i + gap] = value
+        [list[i], list[i + gap]] = [list[i + gap], list[i]]
         isSwapped = true
       }
       i += 1
diff --git a/Sorts/GnomeSort.js b/Sorts/GnomeSort.js
@@ -14,9 +14,7 @@ function gnomeSort (items) {
     if (items[i - 1] <= items[i]) {
       i++
     } else {
-      const temp = items[i]
-      items[i] = items[i - 1]
-      items[i - 1] = temp
+      [items[i], items[i - 1]] = [items[i - 1], items[i]]
 
       i = Math.max(1, i - 1)
     }
diff --git a/Sorts/Heapsort.js b/Sorts/Heapsort.js
@@ -22,10 +22,7 @@ function heapRoot (input, i) {
 }
 
 function swap (input, indexA, indexB) {
-  const temp = input[indexA]
-
-  input[indexA] = input[indexB]
-  input[indexB] = temp
+  [input[indexA], input[indexB]] = [input[indexB], input[indexA]]
 }
 
 function heapSort (input) {
diff --git a/Sorts/SelectionSort.js b/Sorts/SelectionSort.js
@@ -21,9 +21,7 @@ function selectionSort (items) {
     if (min !== i) {
       // After each pass, if the current min num != initial min num, exchange the position.
       // Swap the numbers
-      var tmp = items[i]
-      items[i] = items[min]
-      items[min] = tmp
+      [items[i], items[min]] = [items[min], [items[i]]]
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -59,9 +59,7 @@ function getRandomInt (min, max) {`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`function Swap (arr, x, y) {`
`62`		`- const temp = arr[x]`
`63`		`- arr[x] = arr[y]`
`64`		`- arr[y] = temp`
	`62`	`+ [arr[x], arr[y]] = [arr[y], arr[x]]`
`65`	`63`	`}`
`66`	`64`
`67`	`65`	`// testing`
Original file line number	Diff line number	Diff line change
`@@ -12,9 +12,7 @@ function bubbleSort (items) {`
`12`	`12`	`// Compare the adjacent positions`
`13`	`13`	`if (items[j] < items[j - 1]) {`
`14`	`14`	`// Swap the numbers`
`15`		`- const tmp = items[j]`
`16`		`- items[j] = items[j - 1]`
`17`		`- items[j - 1] = tmp`
	`15`	`+ [items[j], items[j - 1]] = [items[j - 1], items[j]]`
`18`	`16`	`}`
`19`	`17`	`}`
`20`	`18`	`}`
`@@ -47,9 +45,7 @@ function alternativeBubbleSort (arr) {`
`47`	`45`	`swapped = false`
`48`	`46`	`for (let i = 0; i < arr.length - 1; i++) {`
`49`	`47`	`if (arr[i] > arr[i + 1]) {`
`50`		`- const temp = arr[i]`
`51`		`- arr[i] = arr[i + 1]`
`52`		`- arr[i + 1] = temp`
	`48`	`+ [arr[i], arr[i + 1]] = [arr[i + 1], arr[i]]`
`53`	`49`	`swapped = true`
`54`	`50`	`}`
`55`	`51`	`}`
Original file line number	Diff line number	Diff line change
`@@ -22,10 +22,7 @@ function heapRoot (input, i) {`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`function swap (input, indexA, indexB) {`
`25`		`- const temp = input[indexA]`
`26`		`-`
`27`		`- input[indexA] = input[indexB]`
`28`		`- input[indexB] = temp`
	`25`	`+ [input[indexA], input[indexB]] = [input[indexB], input[indexA]]`
`29`	`26`	`}`
`30`	`27`
`31`	`28`	`function heapSort (input) {`
Original file line number	Diff line number	Diff line change
`@@ -21,9 +21,7 @@ function selectionSort (items) {`
`21`	`21`	`if (min !== i) {`
`22`	`22`	`// After each pass, if the current min num != initial min num, exchange the position.`
`23`	`23`	`// Swap the numbers`
`24`		`- var tmp = items[i]`
`25`		`- items[i] = items[min]`
`26`		`- items[min] = tmp`
	`24`	`+ [items[i], items[min]] = [items[min], [items[i]]]`
`27`	`25`	`}`
`28`	`26`	`}`
`29`	`27`	`}`