X Tutup
Skip to content

Commit c854800

Browse files
author
Johan Brichau
authored
Merge pull request SeasideSt#172 from SeasideSt/pharo12
Address Pharo12 deprecations
2 parents ee685e4 + 6667894 commit c854800

File tree

11 files changed

+29
-36
lines changed

11 files changed

+29
-36
lines changed

repository/Grease-Pharo110-Slime.package/GRTestAssertionsRule.class/instance/checkMethod..st

Lines changed: 0 additions & 7 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
SystemOrganization addCategory: #'Grease-Pharo110-Slime'!
1+
self packageOrganizer ensurePackage: #'Grease-Pharo110-Slime' withTags: #()!

repository/Grease-Tests-Pharo-Core.package/GRPharoPlatformTest.class/instance/testCompileIntoClassified.st

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ testCompileIntoClassified
1111
classified: protocol.
1212

1313
[ self assert: (self class selectors includes: selector).
14-
selectors := self class organization listAtCategoryNamed: protocol.
14+
selectors := self class selectorsInProtocol: protocol.
1515
self assert: selectors = (Array with: selector) ] ensure: [ self class removeSelector: selector ]
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
SystemOrganization addCategory: #'Grease-Tests-Pharo-Core'!
1+
self packageOrganizer ensurePackage: #'Grease-Tests-Pharo-Core' withTags: #()!
Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,4 @@
11
accessing-code
22
defineSubClassOf: aSuperSymbol
33

4-
| class |
5-
class := SystemVersion current major >= 12
6-
ifTrue: [
7-
factory make: [ :aBuilder |
8-
aBuilder
9-
superclass: (Smalltalk at: aSuperSymbol);
10-
package: self category ] ]
11-
ifFalse: [
12-
factory
13-
newSubclassOf: (Smalltalk at: aSuperSymbol)
14-
instanceVariableNames: ''
15-
classVariableNames: 'classVarsString'
16-
category: self category ].
17-
environment
18-
addClass: class;
19-
addClass: class classSide.
20-
^ class
4+
^ self defineSubClassOf: aSuperSymbol inPackage: self category
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
accessing-code
2+
defineSubClassOf: aSuperSymbol inPackage: packageName
3+
4+
| class |
5+
class := SystemVersion current major >= 12
6+
ifTrue: [
7+
factory make: [ :aBuilder |
8+
aBuilder
9+
superclass: (Smalltalk at: aSuperSymbol);
10+
package: packageName ] ]
11+
ifFalse: [
12+
factory
13+
newSubclassOf: (Smalltalk at: aSuperSymbol)
14+
instanceVariableNames: ''
15+
classVariableNames: 'classVarsString'
16+
category: packageName ].
17+
environment
18+
addClass: class;
19+
addClass: class classSide.
20+
^ class

repository/Grease-Tests-Pharo-Slime.package/GRReSlimeTest.class/instance/testReferencesNotPortableClass.st

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@ tests-block
22
testReferencesNotPortableClass
33

44
| class |
5-
class := self defineSubClassOf: #GRObject.
6-
class category: 'SomeCategory'.
5+
class := self defineSubClassOf: #GRObject inPackage: 'SomeCategory'.
76
self compile: 'invalid ^ Semaphore new' in: class.
87
self compile: 'valid ^ GRObject new' in: class.
98
self

repository/Grease-Tests-Pharo-Slime.package/GRReSlimeTest.class/instance/testSubclassesNotPortableClass.st

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@ tests-block
22
testSubclassesNotPortableClass
33

44
| class |
5-
class := self defineSubClassOf: #Mutex.
6-
class category: 'SomeCategory'.
5+
class := self defineSubClassOf: #Mutex inPackage: 'SomeCategory'.
76
self
87
assertRule: GRSubclassesNotPortableClassRule
98
matches: { class }

repository/Grease-Tests-Pharo-Slime.package/GRReSlimeTest.class/instance/testTestCaseFailRule.st

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,4 @@ testTestCaseFailRule
66
self compile: 'testMethod self fail' in: class.
77
self
88
runTransformation: GRTestAssertionsRule
9-
changes: #(
10-
'testMethod self assert: false' )
9+
changes: #( 'testMethod self assert: false' )

repository/Grease-Tests-Pharo-Slime.package/GRReSlimeTest.class/instance/testUsesNotPortableClass.st

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@ tests-block
22
testUsesNotPortableClass
33

44
| class |
5-
class := self defineSubClassOf: #GRObject.
6-
class category: 'SomeCategory'.
5+
class := self defineSubClassOf: #GRObject inPackage: 'SomeCategory'.
76
self compile: 'invalid ^ Semaphore new' in: class.
87
self compile: 'valid ^ GRObject new' in: class.
98
self

0 commit comments

Comments
 (0)
X Tutup