Proper fix for GRDynamicVariable in GS2.4

Johan Brichau · Johan Brichau · commit 88120a0632e0 · 2017-10-04T13:36:13.000+02:00
diff --git a/repository/Grease-GemStone-Core.package/GRDynamicVariable.class/class/value.st b/repository/Grease-GemStone-Core.package/GRDynamicVariable.class/class/value.st
@@ -1,5 +1,7 @@
 accessing
 value
-  "Override required for compatibility in GS2.4"
+  "Override required for compatibility in GS2.4 where environmentAt:ifAbsent: is flawed because it can still return nil when absent instead of executing the ifAbsent block"
 
-  ^ Processor activeProcess environmentAt: self ifAbsent: [ self default ]
+  ^ Processor activeProcess environment
+    ifNil: [ self defaultValue ]
+    ifNotNil: [ :env | env at: self ifAbsent: [ self defaultValue ] ]
diff --git a/repository/Grease-GemStone-Core.package/GRDynamicVariable.class/methodProperties.json b/repository/Grease-GemStone-Core.package/GRDynamicVariable.class/methodProperties.json
@@ -3,6 +3,6 @@
 		"default" : "JohanBrichau 07/23/2017 09:48",
 		"defaultValue" : "JohanBrichau 07/23/2017 09:47",
 		"use:during:" : "JB 09/08/2017 00:34",
-		"value" : "JohanBrichau 10/04/2017 04:18" },
+		"value" : "JohanBrichau 10/04/2017 04:35" },
 	"instance" : {
 		 } }
diff --git a/repository/Grease-GemStone-Core.package/monticello.meta/version b/repository/Grease-GemStone-Core.package/monticello.meta/version
