Adapted the method comment in GRDynamicVariable implementation of GemStone to better reflect why we override it.

Johan Brichau · Johan Brichau · commit 6e1d99d80e61 · 2017-09-07T14:39:10.000+02:00
diff --git a/repository/Grease-GemStone-Core.package/GRDynamicVariable.class/class/use.during..st b/repository/Grease-GemStone-Core.package/GRDynamicVariable.class/class/use.during..st
@@ -1,7 +1,7 @@
 accessing
 use: anObject during: aBlock
   | p oldValue result |
-  "Proper implementation instead of use 'super value:during:' because that one does not return value, perhaps this should be fixed in DynamicVariable?"
+  "We cannot just do a super call to value:during: because the GS implementation does not return a result value and also does not produce an error when the dynamic var was not found."
   p := Processor activeProcess.
   oldValue := p environmentAt: self.
   [ 
diff --git a/repository/Grease-GemStone-Core.package/GRDynamicVariable.class/methodProperties.json b/repository/Grease-GemStone-Core.package/GRDynamicVariable.class/methodProperties.json
@@ -2,6 +2,6 @@
 	"class" : {
 		"default" : "JohanBrichau 07/23/2017 09:48",
 		"defaultValue" : "JohanBrichau 07/23/2017 09:47",
-		"use:during:" : "JohanBrichau 07/23/2017 07:39" },
+		"use:during:" : "JohanBrichau 09/07/2017 05:38" },
 	"instance" : {
 		 } }
diff --git a/repository/Grease-GemStone-Core.package/monticello.meta/version b/repository/Grease-GemStone-Core.package/monticello.meta/version

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`accessing`
`2`	`2`	`use: anObject during: aBlock`
`3`	`3`	`\| p oldValue result \|`
`4`		`- "Proper implementation instead of use 'super value:during:' because that one does not return value, perhaps this should be fixed in DynamicVariable?"`
	`4`	`+ "We cannot just do a super call to value:during: because the GS implementation does not return a result value and also does not produce an error when the dynamic var was not found."`
`5`	`5`	`p := Processor activeProcess.`
`6`	`6`	`oldValue := p environmentAt: self.`
`7`	`7`	`[`