Merge pull request SeasideSt#18 from GsDevKit/issue_111

dalehenrich · web-flow · commit 500f5e8d49ed · 2020-10-08T16:24:27.000-07:00
Restore pre-3.6.0 of Exception&gt;&gt;messageText  and Class&gt;&gt;comment
diff --git a/.travis.yml b/.travis.yml
@@ -33,7 +33,7 @@ matrix:
       env: BUILD_NAME=Squeak-5.2
     - smalltalk: Squeak32-5.1
       env: BUILD_NAME=Squeak-5.1
-    - smalltalk: GemStone-3.5.2
+    - smalltalk: GemStone-3.5.4
       env: BUILD_NAME=GemStone-3.5.2
     - smalltalk: GemStone-3.4.5
       env: BUILD_NAME=GemStone-3.4.5
diff --git a/repository/BaselineOfGrease.package/.filetree b/repository/BaselineOfGrease.package/.filetree
@@ -1,5 +1,4 @@
 {
-	"separateMethodMetaAndSource" : false,
 	"noMethodMetaData" : true,
-	"useCypressPropertiesFile" : true
-}
+	"separateMethodMetaAndSource" : false,
+	"useCypressPropertiesFile" : true }
diff --git a/repository/BaselineOfGrease.package/BaselineOfGrease.class/instance/baselineGemStone..st b/repository/BaselineOfGrease.package/BaselineOfGrease.class/instance/baselineGemStone..st
@@ -79,7 +79,7 @@ baselineGemStone: spec
                 requires: #('Grease-GemStone-Core');
                 postLoadDoIt: #'initializeLatin1ToUtf8Encodings' ] ].
   spec
-    for: #(#'gs3.3.x' #'gs3.4.x' #'gs3.5.x' #'gs3.6.x')
+    for: #(#'gs3.3.x' #'gs3.4.x' #'gs3.5.x')
     do: [ 
       spec
         package: 'Grease-GemStone-Core'
@@ -89,6 +89,17 @@ baselineGemStone: spec
               spec
                 requires: #('Grease-GemStone-Core');
                 postLoadDoIt: #'initializeLatin1ToUtf8Encodings' ] ].
+  spec
+    for: #(#'gs3.6.x')
+    do: [ 
+      spec
+        package: 'Grease-GemStone-Core'
+          with: [ spec includes: #('Grease-GemStone360-Core') ];
+        package: 'Grease-GemStone360-Core'
+          with: [ 
+              spec
+                requires: #('Grease-GemStone-Core');
+                postLoadDoIt: #'initializeLatin1ToUtf8Encodings' ] ].
   spec
     for: #(#'gs3.2.x' #'gs3.3.x' #'gs3.4.x' #'gs3.5.x' #'gs3.6.x')
     do: [ 
diff --git a/repository/BaselineOfGrease.package/BaselineOfGrease.class/instance/projectClass.st b/repository/BaselineOfGrease.package/BaselineOfGrease.class/instance/projectClass.st
@@ -1,4 +1,4 @@
 accessing
 projectClass
   Smalltalk at: #'MetacelloCypressBaselineProject' ifPresent: [ :cl | ^ cl ].
-  ^ super projectClass
+  ^ super projectClass
diff --git a/repository/BaselineOfGrease.package/BaselineOfGrease.class/properties.json b/repository/BaselineOfGrease.package/BaselineOfGrease.class/properties.json
@@ -1,11 +1,14 @@
 {
-	"commentStamp" : "",
-	"super" : "BaselineOf",
 	"category" : "BaselineOfGrease",
-	"classinstvars" : [ ],
-	"pools" : [ ],
-	"classvars" : [ ],
-	"instvars" : [ ],
+	"classinstvars" : [
+		 ],
+	"classvars" : [
+		 ],
+	"commentStamp" : "",
+	"instvars" : [
+		 ],
 	"name" : "BaselineOfGrease",
-	"type" : "normal"
-}
+	"pools" : [
+		 ],
+	"super" : "BaselineOf",
+	"type" : "normal" }
diff --git a/repository/BaselineOfGrease.package/monticello.meta/categories.st b/repository/BaselineOfGrease.package/monticello.meta/categories.st
@@ -1 +1 @@
-SystemOrganization addCategory: #BaselineOfGrease!
+SystemOrganization addCategory: #'BaselineOfGrease'!
diff --git a/repository/BaselineOfGrease.package/properties.json b/repository/BaselineOfGrease.package/properties.json
@@ -1 +1,2 @@
-{ }
+{
+	 }
diff --git a/repository/Grease-GemStone360-Core.package/.filetree b/repository/Grease-GemStone360-Core.package/.filetree
@@ -0,0 +1,4 @@
+{
+	"noMethodMetaData" : true,
+	"separateMethodMetaAndSource" : false,
+	"useCypressPropertiesFile" : true }
diff --git a/repository/Grease-GemStone360-Core.package/Class.extension/instance/comment.st b/repository/Grease-GemStone360-Core.package/Class.extension/instance/comment.st
@@ -0,0 +1,9 @@
+*grease-gemstone360-core
+comment
+  "override new 3.6.0 comment implementation (answers default GemSTone class comment for 
+	class instead of nil) and restore pre-3.6.0 behavior (answer nil if no comment 
+	defined)"
+
+  "https://github.com/SeasideSt/Grease/issues/111"
+
+  ^ self commentForFileout
diff --git a/repository/Grease-GemStone360-Core.package/Class.extension/properties.json b/repository/Grease-GemStone360-Core.package/Class.extension/properties.json
@@ -0,0 +1,2 @@
+{
+	"name" : "Class" }
diff --git a/repository/Grease-GemStone360-Core.package/Exception.extension/instance/greaseString.st b/repository/Grease-GemStone360-Core.package/Exception.extension/instance/greaseString.st
@@ -0,0 +1,4 @@
+*grease-gemstone360-core
+greaseString
+
+	^self description
diff --git a/repository/Grease-GemStone360-Core.package/Exception.extension/instance/messageText.st b/repository/Grease-GemStone360-Core.package/Exception.extension/instance/messageText.st
@@ -0,0 +1,5 @@
+*grease-gemstone360-core
+messageText
+	"override new 3.6.0 messageText implementation to restore pre-3.6.0 behavior"
+	"https://github.com/SeasideSt/Grease/issues/111"
+  ^ gsDetails
diff --git a/repository/Grease-GemStone360-Core.package/Exception.extension/properties.json b/repository/Grease-GemStone360-Core.package/Exception.extension/properties.json
@@ -0,0 +1,2 @@
+{
+	"name" : "Exception" }
diff --git a/repository/Grease-GemStone360-Core.package/ExecBlock.extension/instance/argumentCount.st b/repository/Grease-GemStone360-Core.package/ExecBlock.extension/instance/argumentCount.st
@@ -0,0 +1,4 @@
+*grease-gemstone360-core
+argumentCount
+
+	^self numArgs.
diff --git a/repository/Grease-GemStone360-Core.package/ExecBlock.extension/instance/ifCurtailed..st b/repository/Grease-GemStone360-Core.package/ExecBlock.extension/instance/ifCurtailed..st
@@ -0,0 +1,11 @@
+*grease-gemstone360-core
+ifCurtailed: aBlock
+
+	| wasCurtailed |
+	wasCurtailed := true.
+	[
+		self value.
+		wasCurtailed := false.
+	] ensure: [
+		wasCurtailed ifTrue: aBlock.
+	].
diff --git a/repository/Grease-GemStone360-Core.package/ExecBlock.extension/instance/valueWithPossibleArguments..st b/repository/Grease-GemStone360-Core.package/ExecBlock.extension/instance/valueWithPossibleArguments..st
@@ -0,0 +1,9 @@
+*grease-gemstone360-core
+valueWithPossibleArguments: anArray 
+     "Evaluate the block represented by the receiver with the arguments provided."
+  | n args | 
+  (n := self numArgs) == 0 ifTrue: [^self value].
+  args := anArray copy
+		size: n;
+		yourself.
+  ^ self valueWithArguments: args.
diff --git a/repository/Grease-GemStone360-Core.package/ExecBlock.extension/properties.json b/repository/Grease-GemStone360-Core.package/ExecBlock.extension/properties.json
@@ -0,0 +1,2 @@
+{
+	"name" : "ExecBlock" }
diff --git a/repository/Grease-GemStone360-Core.package/GRGemStonePlatform.extension/instance/gemstoneExceptionSelector.st b/repository/Grease-GemStone360-Core.package/GRGemStonePlatform.extension/instance/gemstoneExceptionSelector.st
@@ -0,0 +1,4 @@
+*grease-gemstone360-core
+gemstoneExceptionSelector
+
+	^ (ExceptionSet new) , Halt, AlmostOutOfStack, Breakpoint
diff --git a/repository/Grease-GemStone360-Core.package/GRGemStonePlatform.extension/instance/generateHardBreak.st b/repository/Grease-GemStone360-Core.package/GRGemStonePlatform.extension/instance/generateHardBreak.st
@@ -0,0 +1,5 @@
+*grease-gemstone360-core
+generateHardBreak
+	"Generate a GemStone hard break"
+
+	^Break signal: 'interrupted for Seaside debugging'
diff --git a/repository/Grease-GemStone360-Core.package/GRGemStonePlatform.extension/instance/handlesAlmostOutOfStackException..st b/repository/Grease-GemStone360-Core.package/GRGemStonePlatform.extension/instance/handlesAlmostOutOfStackException..st
@@ -0,0 +1,4 @@
+*grease-gemstone360-core
+handlesAlmostOutOfStackException: anException
+
+	^AlmostOutOfStack handles: anException
diff --git a/repository/Grease-GemStone360-Core.package/GRGemStonePlatform.extension/instance/handlesBreakpointException..st b/repository/Grease-GemStone360-Core.package/GRGemStonePlatform.extension/instance/handlesBreakpointException..st
@@ -0,0 +1,4 @@
+*grease-gemstone360-core
+handlesBreakpointException: anException
+
+	^Breakpoint handles: anException
diff --git a/repository/Grease-GemStone360-Core.package/GRGemStonePlatform.extension/instance/handlesHaltException..st b/repository/Grease-GemStone360-Core.package/GRGemStonePlatform.extension/instance/handlesHaltException..st
@@ -0,0 +1,4 @@
+*grease-gemstone360-core
+handlesHaltException: anException
+
+	^Halt handles: anException
diff --git a/repository/Grease-GemStone360-Core.package/GRGemStonePlatform.extension/properties.json b/repository/Grease-GemStone360-Core.package/GRGemStonePlatform.extension/properties.json
@@ -0,0 +1,2 @@
+{
+	"name" : "GRGemStonePlatform" }
diff --git a/repository/Grease-GemStone360-Core.package/GRUtf8CodecStream.class/README.md b/repository/Grease-GemStone360-Core.package/GRUtf8CodecStream.class/README.md
diff --git a/repository/Grease-GemStone360-Core.package/GRUtf8CodecStream.class/class/initialize.st b/repository/Grease-GemStone360-Core.package/GRUtf8CodecStream.class/class/initialize.st
@@ -0,0 +1,12 @@
+initialization
+initialize
+  "self initialize"
+
+  Latin1ToUtf8Encodings := Array new: 256.
+  1 to: 256 do: [ :index | 
+    index > 128
+      ifTrue: [ 
+        Latin1ToUtf8Encodings
+          at: index
+          put:
+            (String with: (Character codePoint: index - 1)) encodeAsUTF8 asString ] ]
diff --git a/repository/Grease-GemStone360-Core.package/GRUtf8CodecStream.class/instance/crlf.st b/repository/Grease-GemStone360-Core.package/GRUtf8CodecStream.class/instance/crlf.st
@@ -0,0 +1,9 @@
+streaming
+crlf
+	binary
+		ifTrue: [
+			stream nextPut: 13.
+			stream nextPut: 10 ]
+		ifFalse: [
+			stream nextPut: Character cr.
+			stream nextPut: Character lf ]
diff --git a/repository/Grease-GemStone360-Core.package/GRUtf8CodecStream.class/instance/invalidUtf8.st b/repository/Grease-GemStone360-Core.package/GRUtf8CodecStream.class/instance/invalidUtf8.st
@@ -0,0 +1,3 @@
+private
+invalidUtf8
+	^GRInvalidUtf8Error signal: 'Invalid UTF-8 input'
diff --git a/repository/Grease-GemStone360-Core.package/GRUtf8CodecStream.class/instance/next..st b/repository/Grease-GemStone360-Core.package/GRUtf8CodecStream.class/instance/next..st
@@ -0,0 +1,37 @@
+streaming
+next: anInteger
+	"Convert the given string from UTF-8 using the fast path if converting to Latin-1"
+	| outStream byte1 byte2 byte3 byte4 unicode count |
+	outStream := WriteStream on: (String new: anInteger).
+	count := 0.
+	[ count < anInteger and: [ stream atEnd not ] ] whileTrue: [
+		byte1 := stream next.
+		unicode := byte1.
+		(byte1 bitAnd: 16rE0) = 192 ifTrue: [ "two bytes"
+			byte2 := stream next.
+			(byte2 bitAnd: 16rC0) = 16r80 ifFalse: [ self invalidUtf8 ].
+			unicode := ((byte1 bitAnd: 31) bitShift: 6) + (byte2 bitAnd: 63)].
+		(byte1 bitAnd: 16rF0) = 224 ifTrue: [ "three bytes"
+			byte2 := stream next.
+			(byte2 bitAnd: 16rC0) = 16r80 ifFalse: [ self invalidUtf8 ].
+			byte3 := stream next.
+			(byte3 bitAnd: 16rC0) = 16r80 ifFalse: [ self invalidUtf8 ].
+			unicode := ((byte1 bitAnd: 15) bitShift: 12) + ((byte2 bitAnd: 63) bitShift: 6)
+				+ (byte3 bitAnd: 63)].
+		(byte1 bitAnd: 16rF8) = 240 ifTrue: [ "four bytes"
+			byte2 := stream next.
+			(byte2 bitAnd: 16rC0) = 16r80 ifFalse: [ self invalidUtf8 ].
+			byte3 := stream next.
+			(byte3 bitAnd: 16rC0) = 16r80 ifFalse: [ self invalidUtf8 ].
+			byte4 := stream next.
+			(byte4 bitAnd: 16rC0) = 16r80 ifFalse: [ self invalidUtf8 ].
+			unicode := ((byte1 bitAnd: 16r7) bitShift: 18) +
+							((byte2 bitAnd: 63) bitShift: 12) + 
+							((byte3 bitAnd: 63) bitShift: 6) +
+							(byte4 bitAnd: 63)].
+		unicode ifNil: [ self invalidUtf8 ].
+		unicode = 16rFEFF "ignore BOM" ifFalse: [
+			outStream nextPut: (Character codePoint: unicode).
+			count := count + 1 ].
+		unicode := nil ].
+	^outStream contents
diff --git a/repository/Grease-GemStone360-Core.package/GRUtf8CodecStream.class/instance/nextPut..st b/repository/Grease-GemStone360-Core.package/GRUtf8CodecStream.class/instance/nextPut..st
@@ -0,0 +1,17 @@
+streaming
+nextPut: aCharacter
+  "old implementation is very slow !!"
+
+  "   self nextPutAll: (String with: aCharacter)"
+
+  | codePoint |
+  codePoint := aCharacter codePoint.
+  codePoint > 127
+    ifTrue: [ 
+      codePoint > 255
+        ifTrue: [ 
+          | str |
+          str := (String with: aCharacter) encodeAsUTF8intoString.
+          stream nextPutAll: str ]
+        ifFalse: [ stream nextPutAll: (Latin1ToUtf8Encodings at: codePoint + 1) ] ]
+    ifFalse: [ stream nextPut: aCharacter ]
diff --git a/repository/Grease-GemStone360-Core.package/GRUtf8CodecStream.class/instance/nextPutAll..st b/repository/Grease-GemStone360-Core.package/GRUtf8CodecStream.class/instance/nextPutAll..st
@@ -0,0 +1,5 @@
+streaming
+nextPutAll: aString
+  binary
+    ifTrue: [ stream nextPutAll: aString asString ]
+    ifFalse: [ stream nextPutAll: aString _encodeAsUTF8intoString ]
diff --git a/repository/Grease-GemStone360-Core.package/GRUtf8CodecStream.class/properties.json b/repository/Grease-GemStone360-Core.package/GRUtf8CodecStream.class/properties.json
@@ -0,0 +1,14 @@
+{
+	"category" : "Grease-GemStone360-Core",
+	"classinstvars" : [
+		 ],
+	"classvars" : [
+		"Latin1ToUtf8Encodings" ],
+	"commentStamp" : "",
+	"instvars" : [
+		 ],
+	"name" : "GRUtf8CodecStream",
+	"pools" : [
+		 ],
+	"super" : "GRTextOrBinaryCodecStream",
+	"type" : "normal" }
diff --git a/repository/Grease-GemStone360-Core.package/monticello.meta/categories.st b/repository/Grease-GemStone360-Core.package/monticello.meta/categories.st
@@ -0,0 +1 @@
+SystemOrganization addCategory: #'Grease-GemStone360-Core'!
diff --git a/repository/Grease-GemStone360-Core.package/monticello.meta/initializers.st b/repository/Grease-GemStone360-Core.package/monticello.meta/initializers.st
diff --git a/repository/Grease-GemStone360-Core.package/monticello.meta/package b/repository/Grease-GemStone360-Core.package/monticello.meta/package
@@ -0,0 +1 @@
+(name 'Grease-GemStone360-Core')
diff --git a/repository/Grease-GemStone360-Core.package/properties.json b/repository/Grease-GemStone360-Core.package/properties.json
@@ -0,0 +1,2 @@
+{
+	 }

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`{`
`2`		`- "separateMethodMetaAndSource" : false,`
`3`	`2`	`"noMethodMetaData" : true,`
`4`		`- "useCypressPropertiesFile" : true`
`5`		`-}`
	`3`	`+ "separateMethodMetaAndSource" : false,`
	`4`	`+ "useCypressPropertiesFile" : true }`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-SystemOrganization addCategory: #BaselineOfGrease!`
	`1`	`+SystemOrganization addCategory: #'BaselineOfGrease'!`