[pull] master from robotframework:master#72
Open
pull[bot] wants to merge 534 commits intofakegit:masterfrom
Open
[pull] master from robotframework:master#72pull[bot] wants to merge 534 commits intofakegit:masterfrom
pull[bot] wants to merge 534 commits intofakegit:masterfrom
Conversation
…s-1822 New attribute property keywords 1822
Within the selenium options argument of the `Open Browser` keword, if there were trailing semicolons then the keyword would fail. With this change we allow trailing semicolons. In addition the library warns about emtpy options. Fixes #1877
Made a few changes .. - Catch unknown expoected conditions and reopport an error. This can still be improved by adding a here are the known expected conditions as well as a "did you mean ..." type message - Brought in parser so one can use `Element To Be Clickable` instead of `element_to_be_clicable`. Admittedly it seems to simple and realized an issue, of case, as I type this. - Added some test cases
Hadn't realized I do force the expected condition ame to all lower case letters. So just needed to add a test case!
.. and some minor corrections
The new selenium options parser has a slightly different behaviour when it comes to multiple arguments with generious spacing within its option string. In stead of leaving preceeding and trailing spaces it removes those. This change is approved files corrects for this change.
I let this leak in. It shouldn't be there and it looks like it is causing trouble in GitHub Actions
Open browser options bug #1877
Some of the expected conditions expect a locator which is a tuple consisting of the By string [1] and the string containing the locator. I wanted to see what this was like. I am thinking that it would be good to somehow use the libraries locator strategy. Needed to also add to the test page so we had a new element after a delay. [1] https://www.selenium.dev/selenium/docs/api/py/_modules/selenium/webdriver/common/by.html#By
Working on an issue with the Options class gave me deeper insight into how it was working. Brought that experience over to the Service class. Thjis is an initial implementation / rewrite of the Service class. It follows more closely the options class. There is just the one test for now and I see I need to bring in the service argument into Open Browser but this feels like a good start.
… browsers The is just an in ititial commit with some changes which bring the service class down to the point where we create/instantiate the webdrivers for the for the various browsers. Still need some work to actually use what the user provides and to test this code.
Although I have completed the intial implementation of the service class and it's usage, I have discovered unlike the selenium options most if not all of the attributes must be set on the instantiate of the class. So need to rework the parsing (should check signature instead of attributes) and then construct the class with these parameters.
updated *** Setting/Keyword/Variable *** to *** Settings/Keywords/Var…
Update contribution guide
…gories updated *** Setting/Keyword/Variable *** to *** Settings/Keywords/Variables ***
Added Yuri and Lisa as Authors
…oss many versions
Previously the timeout was 1 sec and the alert was delayed 500ms. With a normal execution it seems that that 500ms diference is just not long enough to reasonably expect the alert to appear. In reviewing this test it was shown any delay was useful and the needed time for an alert to triggered and then recognized would need more than 500ms.
Latest versions jun2025
Return screenshot as base64 string and embed into log
Remove deprecated is string
Allow python version 3.14
- Added continuie on error - switched browser on "previous" config to chrome - change setup chrome version to latest
- Switched over to select.yml for pull request and pushes - Renamed the select workflow - Added an older rf version configuration to the test matrix
Added new GitHub Actions workflow and performed yearly update on cookie test suite
Dependabot
Fix typo in deprecation message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )