X Tutup
Skip to content

[pull] master from robotframework:master#72

Open
pull[bot] wants to merge 534 commits intofakegit:masterfrom
robotframework:master
Open

[pull] master from robotframework:master#72
pull[bot] wants to merge 534 commits intofakegit:masterfrom
robotframework:master

Conversation

@pull
Copy link

@pull pull bot commented Dec 10, 2021

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added the ⤵️ pull label Dec 10, 2021
emanlove and others added 29 commits December 19, 2023 18:01
…s-1822

New attribute property keywords 1822
Within the selenium options argument of the `Open Browser` keword, if there were
trailing semicolons then the keyword would fail. With this change we allow trailing
semicolons. In addition the library warns about emtpy options.

Fixes #1877
Made a few changes ..
- Catch unknown expoected conditions and reopport an error. This can still be improved
  by adding a here are the known expected conditions as well as a "did you mean ..."
  type message
- Brought in parser so one can use `Element To Be Clickable` instead of
  `element_to_be_clicable`. Admittedly it seems to simple and realized an issue, of case,
  as I type this.
- Added some test cases
Hadn't realized I do force the expected condition ame to all lower case letters. So just needed
to add a test case!
The new selenium options parser has a slightly different behaviour when
it comes to multiple arguments with generious spacing within its option
string. In stead of leaving preceeding and trailing spaces it removes those.
This change is approved files corrects for this change.
I let this leak in. It shouldn't be there and it looks like it is causing trouble in
GitHub Actions
Some of the expected conditions expect a locator which is a tuple
consisting of the By string [1] and the string containing the locator.
I wanted to see what this was like. I am thinking that it would be good
to somehow use the libraries locator strategy.

Needed to also add to the test page so we had a new element after a delay.

[1] https://www.selenium.dev/selenium/docs/api/py/_modules/selenium/webdriver/common/by.html#By
Working on an issue with the Options class gave me deeper insight into how it was working. Brought that experience over to
the Service class. Thjis is an initial implementation / rewrite of the Service class. It follows more closely the options class.
There is just the one test for now and I see I need to bring in the service argument into Open Browser but this feels like
a good start.
… browsers

The is just an in ititial commit with some changes which bring the service class down to
the point where we create/instantiate the webdrivers for the for the various browsers.
Still need some work to actually use what the user provides and to test this code.
Although I have completed the intial implementation of the service class and
it's usage, I have discovered unlike the selenium options most if not all of the attributes
must be set on the instantiate of the class. So need to rework the parsing (should check
signature instead of attributes) and then construct the class with these parameters.
updated *** Setting/Keyword/Variable *** to *** Settings/Keywords/Var…
…gories

updated *** Setting/Keyword/Variable *** to *** Settings/Keywords/Variables ***
emanlove and others added 30 commits August 3, 2025 09:42
Previously the timeout was 1 sec and the alert was delayed 500ms. With a normal execution
it seems that that 500ms diference is just not long enough to reasonably expect the alert
to appear. In reviewing this test it was shown any delay was useful and the needed time
for an alert to triggered and then recognized would need more than 500ms.
Return screenshot as base64 string and embed into log
- Added continuie on error
- switched browser on "previous" config to chrome
- change setup chrome version to latest
- Switched over to select.yml for pull request and pushes
- Renamed the select workflow
- Added an older rf version configuration to the test matrix
Added new GitHub Actions workflow and performed yearly update on cookie test suite
Fix typo in deprecation message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

X Tutup