Update gradle wrapper to latest release for local Java 17 support.#2083
Merged
jmrunkle merged 2 commits intoexercism:mainfrom Jan 6, 2022
ericbalawejder:update-gradle-wrapper-version
Merged
Update gradle wrapper to latest release for local Java 17 support.#2083jmrunkle merged 2 commits intoexercism:mainfrom ericbalawejder:update-gradle-wrapper-version
jmrunkle merged 2 commits intoexercism:mainfrom
ericbalawejder:update-gradle-wrapper-version
Conversation
Contributor
Author
|
My second commit changes the version from 7.3.3 to 7.3 to be more consistent with the test runner. |
jmrunkle
approved these changes
Jan 6, 2022
Contributor
jmrunkle
left a comment
jmrunkle
left a comment
There was a problem hiding this comment.
Looks fine, I just do not know if it is technically tested by the automated tests. Not even sure if it is testable due to integration with the cli stuff.
Contributor
Author
|
I had similar concerns in #2034 about the local cli environment. I believe the github actions run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the Gradle wrapper to the latest version. This version supports Java 17 for local use when fetching from the Exercism command line client. The Java test runner for the web editor currently supports Java 17. This addresses issue #2034
Reviewer Resources:
Track Policies