Use api for marking transitive compile+runtime dependencies#699
Merged
jabrena merged 2 commits intoev3dev-lang-java:masterfrom Dec 2, 2019
JakubVanek:bugfix/transitive_dependencies
Merged
Use api for marking transitive compile+runtime dependencies#699jabrena merged 2 commits intoev3dev-lang-java:masterfrom JakubVanek:bugfix/transitive_dependencies
api for marking transitive compile+runtime dependencies#699jabrena merged 2 commits intoev3dev-lang-java:masterfrom
JakubVanek:bugfix/transitive_dependencies
Conversation
We have previously switched from `compile` to `implementation`. This had an unexpected consequence, however - `implementation` does not make dependencies transitive. The quick fix is to switch back to `compile`, which is marked as deprecated, however. As an alternative, there exists an `api` label in the `java-library` Gradle plugin. According to https://stackoverflow.com/a/53726023 , this plugin extends the Java plugin and provides functionality for Java libraries, which is exactly what is needed.
Member
|
Upgrade the version to the next patch version: |
jabrena
approved these changes
Dec 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have previously switched from
compiletoimplementation.This had an unexpected consequence, however -
implementationdoes not make dependencies transitive. The quick fix is to
switch back to
compile, which is marked as deprecated, however.As an alternative, there exists an
apilabel in thejava-libraryGradle plugin. According to https://stackoverflow.com/a/53726023 ,
this plugin extends the Java plugin and provides functionality
for Java libraries, which is exactly what is needed.