X Tutup
Skip to content

Ease-of-development updates/fixes in README#4

Merged
dlech merged 2 commits intoev3dev:ev3dev-jessiefrom
WasabiFan:patch-1
Sep 19, 2017
Merged

Ease-of-development updates/fixes in README#4
dlech merged 2 commits intoev3dev:ev3dev-jessiefrom
WasabiFan:patch-1

Conversation

@WasabiFan
Copy link
Copy Markdown
Member

  • Update branch name master to be ev3dev-jessie
  • Include u-boot-tools package for EV3
  • Include gcc-linaro-arm-linux-gnueabihf-5.2 for EV3. This seems suspicious as I believe the EV3 is soft-float, but an error was thrown when trying to find a compiler with that specific name before I installed it.
  • Clone kernel repo with --depth 50 to save time while cloning. This is dramatically faster, and git versions from 2016+ remove the past limitations on pushing/pulling with a shallow clone. Very few people need the history.

@WasabiFan
Copy link
Copy Markdown
Member Author

I only made these changes for Jessie but the commit can probably be cherry-picked if desired.

@dlech
Copy link
Copy Markdown
Member

dlech commented Sep 19, 2017

The readme already says:

Plus any of the following that apply...

  • For EV3 or Beaglebone kernel:
sudo apt-get install u-boot-tools lzop gcc-linaro-arm-linux-gnueabihf-5.2

So adding it again just one line above that seems a bit redundant.

The kernel doesn't use floating point at all, so we don't get illegal instructions. Vendors haven't released a toolchain really suitable for EV3 since 2014 or so.

Suggestion to use --depth is good idea.

@WasabiFan
Copy link
Copy Markdown
Member Author

Ah, that makes a bit more sense; I didn't notice that EV3 was included with BB. What do you think about separating it into three individual commands with all the prereqs for each platform to make it obvious? The way I read it was that the default set of packages was listed in the large block, and then if you needed one of the other two you should replace the command with the following one.

@dlech
Copy link
Copy Markdown
Member

dlech commented Sep 19, 2017

You are the first person I know of to miss it. 😉

I don't really care if it is separated. I think the lzop is only needed for BeagleBone and not EV3. The other packages are used by both.

@WasabiFan
Copy link
Copy Markdown
Member Author

I'm happy to be the low bar for testing worst-case scenario 😛

@dlech dlech merged commit 824fb34 into ev3dev:ev3dev-jessie Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup