Conversation
Remove windows from the list of OS to avoid matrix creation. Remove windows from the exclusion list (which seems to have reversed priority with include). Left windows as explicit inclusion
Owner
Author
|
See conversation here too: #186 |
1 task
Owner
Author
|
The state of build on windows in travis seems to have actually worsened. I see a large number of timeouts during the installation of msys2 and autotools through choco and pacman. |
This to test whether this is the reason for the missing inet_ntop on windows builds
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
=======================================
Coverage 95.19% 95.19%
=======================================
Files 35 35
Lines 3140 3140
=======================================
Hits 2989 2989
Misses 151 151
Continue to review full report at Codecov.
|
Owner
Author
|
For some reason, the re-ordering seemed to have been preventing the import of the correct libraries. Need to investigate - I will use this branch to fix it before pushing out. |
This respects the ordering of the libraries we have just established
Use the recommended way from travis: https://docs.travis-ci.com/user/reference/windows/#how-do-i-use-msys2
Eliminate additional differences between linux and windows builds.
Rely on the same configuration used on other systems.
libmicrohttpd seems to be failing on mingw+msys2. It deduces poll is enabled but then misses definitions.
Needed to run tests
Needed a libcurl doesn't seem to be obtaining it properly from the servers on windows: see: https://curl.haxx.se/mail/lib-2015-02/0174.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug
Recovers the build on windows in travis - travis is not building on windows anymore seemingly due to an inversion in priority of exclude and include.
Description of the Change
As travis seems to have inverted the priority of exclude and include, the windows build is missing. This attempts to obtain the windows build again by:
Alternate Designs
Full support for the windows build matrix. Not currently possible due to the limited support from travis for windows.
Possible Drawbacks
Errors in build. Discoverable through CI.
Verification Process
Running the CI process.
Release Notes
CI builds on windows again.