Refactor, resolve some issues#51
Merged
ethangreen-dev merged 15 commits intoethangreen-dev:masterfrom Jun 30, 2024
Merged
Conversation
english5040
changed the title
ethangreen-dev
requested changes
Jun 29, 2024
Owner
ethangreen-dev
left a comment
ethangreen-dev
left a comment
There was a problem hiding this comment.
This is a great improvement to the codebase, good work!
Owner
|
Closes #23 |
crop doesn't work yet, it's missing into_cursor()
Gives crop an into_cursor() function.
(need raw_lines())
change log:info to warn use a link for latest release
Owner
|
Going to merge this as-is for convenience. |
ethangreen-dev
approved these changes
Jun 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.