Conversation
|
✅Static analysis result - no issues found! ✅ |
|
Contributor
Author
|
@Noorsun0035 Can you please open this as a discussion instead of on this issue specifically? I'd recommend opening a new discussion for the first question. Regarding your second question, I've included PDFs of the schematics and board files in the The
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Makes genesis much more enjoyable to play on this hardware :)
How has this been tested?
Building and running on box-3-emu and listening to how much better the genesis sound emulation is and seeing how much better it runs (and esp. when sound is off!)
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
With sound (slower, but sound is much improved):
improved-genesis-compressed.mp4
Muted (buttery smooth):
muted-sonic.mp4
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.