X Tutup
Skip to content

Implement the First Part of Regex Support#1968

Merged
iamrecursion merged 33 commits intomainfrom
wip/ara/regex
Aug 23, 2021
Merged

Implement the First Part of Regex Support#1968
iamrecursion merged 33 commits intomainfrom
wip/ara/regex

Conversation

@iamrecursion
Copy link
Contributor

@iamrecursion iamrecursion commented Aug 20, 2021 •
edited
Loading

Pull Request Description

Implements the first part of #1922 and provides support for these on Text, as well as a comprehensive lower-level API.

Important Notes

N/A

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@iamrecursion
Partial regex implementation
28c2940
@iamrecursion
Clean up for a new approach
b9d85c0
@iamrecursion
Make it match the first instance
1d8692a
@iamrecursion
Implement a more sensible Match + shotgun parser
922dca5
@iamrecursion
Remove the old Match
68a0a74
@iamrecursion
Implement the basic match modes
cf5adef
@iamrecursion
Implement .match for the default engine
9ab5edd
@iamrecursion
Implement .find
a2449ce
@iamrecursion
Implement .split
0a7b8c0
@iamrecursion
Implement .replace
c3dbeba
@iamrecursion
Add .matches
257e6cf
@iamrecursion
Document the Pattern methods
a0b9404
@iamrecursion
Document the default engine interface
2a44bb1
@iamrecursion
Doc the default engine
020c5cf
@iamrecursion
Fix some docs
6b05a7f
@iamrecursion
Add a function for options collation
1aa46c3
@iamrecursion
Add tests for the entry-point functionality
9b571cc
@iamrecursion
Move things to Text.Extensions where relevant
66bf24d
@iamrecursion
Fix an issue where counted replacements wouldn't work properly
ed03b26
@iamrecursion
Implement Text.match
30492ee
@iamrecursion
Make the comment remover a bit less dumb
83a4beb
@iamrecursion
Add Text.matches
04c91f0
@iamrecursion
Implement Text.find
3337927
@iamrecursion
Re-implement Text.split with Regex
73375b8
@iamrecursion
Test the Text.split regex support
fdcd666
@iamrecursion
Use Regex in Text.replace
0ad3a2e
@iamrecursion
Add some basic examples
747934c
@iamrecursion
Clarify some stuff on escaping
7a61f9c
@iamrecursion iamrecursion requested a review from kustosz August 20, 2021 11:49
@iamrecursion iamrecursion self-assigned this Aug 20, 2021
@iamrecursion iamrecursion added the p-highest Should be completed ASAP label Aug 20, 2021
@iamrecursion iamrecursion marked this pull request as ready for review August 20, 2021 11:56
kustosz
kustosz approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@kustosz kustosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval conditional on the nitpicks left inline :)

@iamrecursion iamrecursion merged commit c18fe2d into main Aug 23, 2021
@iamrecursion iamrecursion deleted the wip/ara/regex branch August 23, 2021 11:09
iamrecursion added a commit that referenced this pull request Aug 23, 2021
@iamrecursion
Provide regex support on Text (#1968)
8118860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@4e6 4e6 Awaiting requested review from 4e6

@radeusgd radeusgd Awaiting requested review from radeusgd

1 more reviewer

@kustosz kustosz kustosz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iamrecursion iamrecursion

Labels

p-highest Should be completed ASAP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iamrecursion @kustosz
X Tutup