Fix a Crash when Project Names are Shadowed#1571
Conversation
iamrecursion
added
Type: Bug
--breaking
iamrecursion
force-pushed
the
wip/ara/project-shadow
branch
from
1bf6e7a to
e312c29
Compare
radeusgd
left a comment
radeusgd
left a comment
There was a problem hiding this comment.
I have only looked at the legal review so far, but there are already a few things that I think are worth resolving, so I'm submitting these comments already.
I'll look at other parts and submit them as a separate comment.
tools/legal-review/Standard/com.ibm.icu.icu4j-67.1/copyright-keep
Outdated
Show resolved
Hide resolved
tools/legal-review/Standard/org.xerial.sqlite-jdbc-3.34.0/copyright-keep
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
One more comment inline.
Also I have noticed by doing a search in the repo state as of the latest commit in this PR, that the test for the Rust lexer enso_lexer_combined.rs still uses the old from Base import all. Is this deliberate?
I think the release.yml workflow needs to have the verifyGeneratedPackage entries updated because they now refer to inexistent directories. Given that the changes are big, before merging this PR a test release should be done on staging to ensure that the workflow is still working correctly.
Other than that it looks good.
engine/runtime/src/main/java/org/enso/interpreter/runtime/Context.java
Outdated
Show resolved
Hide resolved
engine/polyglot-api/src/test/scala/org/enso/polyglot/ModuleManagementTest.scala
Show resolved
Hide resolved
iamrecursion
force-pushed
the
wip/ara/project-shadow
branch
from
9b8dec9 to
41107ad
Compare
iamrecursion
force-pushed
the
wip/ara/project-shadow
branch
from
264d274 to
81d2808
Compare
3 participants
Pull Request Description
As in the title. In addition, it namespaces all of the standard library packages under
Standard.Closes #1558.
Important Notes
Found a bug in imports resolution, but that will be fixed in a separate task.
Checklist
Please include the following checklist in your PR: