Add Time Profiling Information to the Protocol#1407
Merged
iamrecursion merged 18 commits intomainfrom Jan 19, 2021
Merged
Conversation
Make time do the thing Checkpoint Partially-working tests Reformat Nondeterministic failure fix: RuntimeServerTest
…o wip/ara/time-profiling
iamrecursion
requested review from
kustosz,
lolczak and
radeusgd
as code owners
4e6
approved these changes
Jan 19, 2021
Contributor
4e6
left a comment
4e6
left a comment
There was a problem hiding this comment.
Just comments about the naming. Approving because can't come up with a better name myself
engine/runtime/src/main/java/org/enso/interpreter/instrument/IdExecutionInstrument.java
Show resolved
Hide resolved
iamrecursion
added a commit
that referenced
this pull request
Feb 10, 2021
iamrecursion
added a commit
that referenced
this pull request
Feb 11, 2021
iamrecursion
added a commit
that referenced
this pull request
Feb 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds an extensible mechanism for sending profiling information about introspected expressions to the IDE. It also includes temporal profiling by default, measuring the wall-clock execution time of the attached expression. Please note that we send the raw values. Doing nice display things with them (e.g. a moving average) is the responsibility of the IDE.
Closes #1353.
Important Notes
N/A
Checklist
Please include the following checklist in your PR: