Merged
Conversation
mdcoury
approved these changes
Apr 21, 2023
Member
Author
|
Though I see we have some new errors coming in from dimod. Off to fix those upstream... Not sure why we're only getting them now. That dimod code isn't new 🤔 |
dimod 0.12.3 adds some includes that were missing in dimod/abc.h
Member
Author
|
Ah, looks like I already fixed it in dimod 0.12.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup on #68. The only warnings still suppressed are the pragma ones because we may want to reintroduce OpenMP at some point.